Merge pull request #687 from Akeit0/master

Fix unintended multiple registrations
hadashiA · Jun 25, 2024 · 17e5789 · 17e5789
2 parents 129dc92 + 3e1846f
commit 17e5789
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/...tainer/Assets/VContainer/Runtime/Internal/InstanceProviders/CollectionInstanceProvider.cs b/...tainer/Assets/VContainer/Runtime/Internal/InstanceProviders/CollectionInstanceProvider.cs
@@ -98,8 +98,11 @@ internal void CollectFromParentScopes(
                 if (scope.TryGetRegistration(finderType, out var registration) &&
                     registration.Provider is CollectionInstanceProvider parentCollection)
                 {
-                    mergedRegistrations = mergedRegistrations ?? ListPool<Registration>.Get();
-                    mergedRegistrations.AddRange(registrations);
+                    if (mergedRegistrations == null)
+                    {
+                        mergedRegistrations = ListPool<Registration>.Get();
+                        mergedRegistrations.AddRange(registrations);
+                    }
 
                     if (localScopeOnly)
                     {