Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fine tuning for web app purpose #1126

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Fine tuning for web app purpose #1126

wants to merge 14 commits into from

Conversation

VGPReys
Copy link
Contributor

@VGPReys VGPReys commented Oct 31, 2024 •
edited
Loading

Checklist

  • Tests added for the new code
  • Documentation added for the code changes
  • Does not break licensing
  • Does not add any dependencies, if it does please add a thorough explanation

Summary of the Pull Request

Does multiple not really related things (not best practice):

  • Removes ALL mpi.pkl files at cleaning stage.
  • Add a new optional global parameter: gen_archive (by default false), allowing to trigger:
    • Generation of a two .tgz archives, one containing the run_directory, the other one containing the analysis directory
    • Generates a local copy of structures in the analysis directory for it to be self contained
    • Adding instructions (README.md) helping/guiding the user on how to setup the local server for visualizing structures in the analysis directory

Related Issue

#1116

@VGPReys VGPReys changed the title 1116 finetunes 4 webapp Fine tuning for web app purpose Oct 31, 2024
@VGPReys VGPReys self-assigned this Nov 1, 2024
@VGPReys VGPReys added enhancement Enhancing an existing feature of adding a new one execution Related to execution modes, such as GRID, HPC, local, etc. labels Nov 1, 2024
@VGPReys VGPReys requested a review from a team November 1, 2024 16:35
VGPReys
VGPReys commented Dec 6, 2024
View reviewed changes
src/haddock/gear/greetings.py Outdated Show resolved Hide resolved
@VGPReys VGPReys requested review from mgiulini and removed request for a team January 29, 2025 10:13
mgiulini
mgiulini previously approved these changes Jan 30, 2025
View reviewed changes
@mgiulini @VGPReys
Update src/haddock/clis/cli_analyse.py
3d1920c 
Co-authored-by: Victor Reys <132575181+VGPReys@users.noreply.github.com>
@VGPReys VGPReys requested a review from a team February 3, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgiulini mgiulini mgiulini approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@VGPReys VGPReys

Labels
enhancement Enhancing an existing feature of adding a new one execution Related to execution modes, such as GRID, HPC, local, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VGPReys @mgiulini