Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ordering by size in clustrmsd #974

Merged
merged 14 commits into from
Sep 10, 2024
Merged

ordering by size in clustrmsd #974

merged 14 commits into from
Sep 10, 2024

Conversation

mgiulini
Copy link
Contributor

@mgiulini mgiulini commented Aug 13, 2024

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:

  • You have sticked to Python. Please talk to us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there is a (state) purpose
  • Your code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any dependencies, unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

Closes #955 by ordering cluster by size in clustrmsd

@mgiulini mgiulini self-assigned this Aug 13, 2024
@mgiulini mgiulini added enhancement Enhancing an existing feature of adding a new one m|clustrmsd labels Aug 13, 2024
@mgiulini mgiulini marked this pull request as draft August 13, 2024 10:14
VGPReys
VGPReys previously approved these changes Aug 14, 2024
Co-authored-by: Victor Reys <132575181+VGPReys@users.noreply.github.com>
@mgiulini mgiulini marked this pull request as ready for review August 23, 2024 07:15
Copy link
Member

@amjjbonvin amjjbonvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - once the main branch has been merged into it

@amjjbonvin amjjbonvin merged commit 2e84ab3 into main Sep 10, 2024
4 checks passed
@amjjbonvin amjjbonvin deleted the cluster_size_clustrmsd branch September 10, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancing an existing feature of adding a new one m|clustrmsd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change cluster IDs to reflect cluster sizes in clustrmsd
3 participants