Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand pathspec range #186

Merged
merged 2 commits into from
Jan 3, 2023
Merged

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented Dec 31, 2022

pathspec 0.10.3 is properly marked as py.typed. I would like to use it, but it conflicts with pycln's version range.

pip install pathspec>=0.10.3

Collecting pathspec>=0.10.3
  Using cached pathspec-0.10.3-py3-none-any.whl (29 kB)
Installing collected packages: pathspec
  Attempting uninstall: pathspec
    Found existing installation: pathspec 0.10.2
    Uninstalling pathspec-0.10.2:
      Successfully uninstalled pathspec-0.10.2
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
pycln 2.1.1 requires pathspec<0.10.0,>=0.9.0, but you have pathspec 0.10.3 which is incompatible.

image

So I changed the version range to allow pathspec ^0.10 and ran poetry lock to update the lock file.

@hadialqattan
Copy link
Owner

hadialqattan commented Jan 2, 2023

@Avasam this pr lgtm so far, but are you sure that we really need to do a poetry lock?

for now, I'll remove the lock file from this pr. waiting for your response before merging.

+ thanks for contributing to Pycln.

@codeclimate
Copy link

codeclimate bot commented Jan 2, 2023

Code Climate has analyzed commit f0c3393 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Merging #186 (f0c3393) into master (8ea90d2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #186   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         2872      2872           
=========================================
  Hits          2872      2872           

@Avasam
Copy link
Contributor Author

Avasam commented Jan 2, 2023

@Avasam this pr lgtm so far, but are you sure that we really need to do a poetry lock?

for now, I'll remove the lock file from this pr. waiting for your response before merging.

  • thanks for contributing to Pycln.

Tbh I'm less familiar with poetry. If poetry.lock works anything like a package-lock.json: usually it'll be the exact versions of all dependencies to be used by the CI (so any change in poetry should come with a lockfile update). So I did what I think is the proper procedure, but clearly the CI didn't like that.

As long as I can install both pycln and pathspec>=0.10.3 together without a pip install warning/error I really don't mind.

@hadialqattan hadialqattan merged commit 4fd989d into hadialqattan:master Jan 3, 2023
@Avasam Avasam deleted the typed-pathspec branch January 3, 2023 23:52
@Avasam
Copy link
Contributor Author

Avasam commented Jan 14, 2023

Thanks for the merge. Mind if I ask when there could be a new patch release?

@hadialqattan
Copy link
Owner

Thanks for the merge. Mind if I ask when there could be a new patch release?

TBH, the next release will be released after at least solving the opened issues #187 and #185. expect that to get done within two weeks. Thank you.

@hadialqattan
Copy link
Owner

Thanks for the merge. Mind if I ask when there could be a new patch release?

@Avasam a new Pycln release has just been released (v2.1.3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants