Port lazy functions to rlang #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 96.94% (diff: 88.88%)@@ master #92 diff @@
==========================================
Files 15 14 -1
Lines 354 327 -27
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 348 317 -31
- Misses 6 10 +4
Partials 0 0
|
|
dplyr passes R CMD check with this branch, I'm currently running |
hadley
reviewed
Nov 14, 2016
| } | ||
| } else { | ||
| env | ||
| if (!missing(default_env)) { |
There was a problem hiding this comment.
Maybe need !missing(defaul_env) && !is.null(default_env) ?
Yes I'll write the rationale for switching from promise-climbing to stack-climbing and for forking rlang from lazyeval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.