fix: update deprecated commands #65
Conversation
mrdoodles
force-pushed
the
fix-github-deprecations
branch
from
f57dc7f
to
68a2276
Compare
| echo "results<<EOF" >> $GITHUB_OUTPUT | ||
| echo "${RESULTS}" >> $GITHUB_OUTPUT | ||
| echo "EOF" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
wait does this actually work?
There was a problem hiding this comment.
Yes I tested in a local non forked copy of the repository:
The Code Changes: https://github.com/mrdoodles/hadolint-local/pull/3/files
The Run: https://github.com/mrdoodles/hadolint-local/actions/runs/3431727905/jobs/5720205348
There was a problem hiding this comment.
Why not just a simple way e.g.
echo "results=${RESULTS}" >> $GITHUB_OUTPUT ?
EOF syntax makes sense to use for multiline things, but there is one line echo.
There was a problem hiding this comment.
Basically this PR https://github.com/hadolint/hadolint-action/pull/64/files does it as well
There was a problem hiding this comment.
@ViacheslavKudinov Because during my test the output actually was a multiline string so it failed with the simple format which was my original commit that failed and i force pushed over.
You can see the output from using the simple method here: https://github.com/hadolint/hadolint-action/actions/runs/3307229271/jobs/5671320194
There was a problem hiding this comment.
Got it. Thanks @mrdoodles for clarification.
There was a problem hiding this comment.
Having said that I have just tried it again and it has passed:
My local test pull: https://github.com/mrdoodles/hadolint-local/pull/7
The workflow run: https://github.com/mrdoodles/hadolint-local/actions/runs/3443878466/jobs/5745890302
Could it be that sometimes there is multiline output in which case the longer format offers a better solution as it handles both scenarios?
There was a problem hiding this comment.
The delimeter shouldn't be randomly generated? Like in this article : https://lab.amalitsky.com/posts/2022/github-actions-set-output-migration/
|
thanks! |
Fix issue #63
updated
Update deprecated set-output to use the new format for multi-line strings as described in the GitHub documentation:
(https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#multiline-strings)
Also updated actions/checkout to the non-deprecated v3.
@austinpray-mixpanel Needed to update this for multi-line string handling, can you review please, thanks