Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Fix some bugs #330

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix some bugs #330

wants to merge 3 commits into from

Conversation

aznhe21
Copy link
Contributor

@aznhe21 aznhe21 commented Oct 12, 2022

This PR fixes these bugs:

  1. Running :HopVerticalAC when the cursor is on an empty line will print "col value outside range".
  2. Running :HopVerticalMW when there is a floating window will print Invalid buffer id: N.
  3. A potential issue that could cause "Not allowed to change text or change window".

@uplus
Copy link

uplus commented Oct 24, 2022

I had this problem with HopLineStartAC in my environment.
This PR fixed it! Thanks!

  1. Running :HopVerticalAC when the cursor is on an empty line will print "col value outside range".

@hadronized
Copy link
Owner

Can you document your changes? The plugin starts to become a mess with all the changes in the PRs trying to fix that problem, I will probably refactor all of that in a couple of days and I need to understand exactly what does what.

@aznhe21
Copy link
Contributor Author

aznhe21 commented Nov 8, 2022

Sorry for the late reply. I have added comments about the changes. Please check it out.

@FelipeLema
Copy link
Contributor

I'm using this branch and it seems to fix #335 👍🏾

@chaudry-786
Copy link

Any progress on this?

@aznhe21
Copy link
Contributor Author

aznhe21 commented Dec 8, 2022

I'm waiting (for over a month!) for a review.
@phaazon Please confirm and merge.

@snaveevans
Copy link

@phaazon any chance this could get reviewed and merged?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants