It is an error to incompatibly override an equivalence constraint. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadronized
reviewed
Apr 13, 2017
| trait IntIterator = Iterator<Item=i32>; | ||
|
|
||
| fn quux1<T: SharableIterator<Item=f64>>(...) { ... } // ok | ||
| fn quux2<T: IntIterator<Item=i32>>(...) { ... } // ok (perhaps subject to lint warning) |
There was a problem hiding this comment.
I think this shoudn’t be authorized?
There was a problem hiding this comment.
I am happy either way.
Originally I was going to list it as disallowed, as you suggest.
But then I worried that might not be consistent with other design choices. E.g. one can add where clauses that are already implied by pre-existing constraints, right? So should it be an error to add a redundant equivalence constraint?
Maybe best (or at least easiest in terms of getting the RFC merged) to take out the fn quux2 example, and then make a new Unresolved Question for this case?
There was a problem hiding this comment.
Well, I think you’re right about the consistency. Others construct follow such a pattern. I’ll merge it then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another detail that I had wanted spelled out explicit in the RFC; see rust-lang#1733 (comment)
(I am assuming that we want it to be legal to put in redundant constraints; that's the case I wrote that we might issue a lint warning for in the text I'm adding here. But maybe this is actually an unresolved question?)