Update support/HAFS from NCAR dtc/hwrf-physics 2020/06/19 #5

climbfuji · 2020-06-19T15:25:43Z

This PR adds the HWRF physics to fv3atm. All development was made in the NCAR fork, branch dtc/hwrf-physics. Commit log from this branch:

04/06/2020 MONINEDMF https://github.com/NCAR/ufs-weather-model/pull/15 -> https://github.com/NCAR/ufs-weather-model/pull/35
    git cherry-pick e6fe22ffde6425800b7ed2e1cf3748b606806d28
    git cherry-pick a99d5e73f94f5ffb3bd9bbb1a3dc04171026b6d7
    git cherry-pick 5570528f22a9815437e0ef5b413435a8b9fd5881
    git cherry-pick 2bb15be8cc15c69c178b6e443c0ab8c0d75ef318

04/08/2020 RRTMG https://github.com/NCAR/ufs-weather-model/pull/30 -> https://github.com/NCAR/ufs-weather-model/pull/36
    git cherry-pick 5ab446fe423d9a7ba0172ec782e6346c47c98116
    git cherry-pick 1cbc515c6dff00e729523ff6f922e046179d7dcf
    git cherry-pick c6f51f5090411c737a8d79a27bbf08b8d9b00c28
    git cherry-pick 2a43ab170916fbe60c3d918ff16a510928964e51
    git cherry-pick 73f5dcbc93ae297a6a9880988a8f7a7109f99c2e

04/13/2020 SAS https://github.com/ufs-community/ufs-weather-model/pull/94 -> https://github.com/NCAR/ufs-weather-model/pull/39
    (entire PR)

04/16/2020 FA MP updates https://github.com/NCAR/ufs-weather-model/pull/41 (replaced https://github.com/NCAR/ufs-weather-model/pull/25)
    (entire PR)

05/04/2020 FA/HWRF RRTMG/HWRF SAS bugfixes https://github.com/NCAR/ufs-weather-model/pull/45
    (entire PR)

05/20/2020 update from HAFS community https://github.com/NCAR/ufs-weather-model/pull/48
    (entire PR)

06/18/2020 update from HAFS community https://github.com/NCAR/ufs-weather-model/pull/56
    (entire PR)

Associated PRs:
#5
hafs-community/fv3atm#5
hafs-community/ccpp-physics#2

For regression testing information, see below NOT YET.

…nd testing

…n configuration required other than one namelist value - hurr_pbl = T)

…r consulting with Weiguo Wang)

…ist for HWRF PBL, add test to rt_ccpp_dtc.conf

…nd testing; add README_HWRF_PHYSICS.txt

…ccpp_regional_c768_FA_update_moist and fv3_ccpp_regional_c768_HWRF_PBL

…retched_nest and fv3_(ccpp_)regional_c768

…o set up the tests

…dd-moninedmf dtc/hwrf-physics: combined version of HAFS/GFS moninedmf scheme (hybrid EDMF PBL)

…nd testing

…to rt.conf

…irst three hours, not just the first one

… CNTL_DIR

…est namelist templates and run scripts, use own HWRF regression test baseline

…dd_rrtmg dtc/hwrf-physics: HWRF RRTMG (based on ufs-community#30)

…fs-weather-model into merge_hwrf-sasas_into_dtc_hwrf-physics

mzhangw

looks good to me

… setup scripts

climbfuji · 2020-06-19T22:58:32Z

Regression testing on hera.intel against official EMC baseline (using rt.conf): all tests passed.

rt_hera_intel.log
RegressionTests_hera.intel.log
Compile_hera.intel.log

climbfuji · 2020-06-19T23:36:41Z

Regression testing on hera.intel using rt_hwrf_physics.conf against previous regression test baseline created with the NCAR dtc/hwrf-physics branch: all tests passed.

rt_hwrf_physics_hera_intel.log

climbfuji · 2020-06-19T23:37:24Z

@BinLiu-NOAA all three PRs listed as associated PRs above are ready to merge from our side. Please let me know next week when you are ready and we can get started with the merge.

Thanks!

BinLiu-NOAA · 2020-06-19T23:57:55Z

Thanks, @climbfuji ! Once @mzhangw pushed her feature/hwrf_physics branch of HAFS into the hafs-community fork, we will start some workflow level regression tests. After that, we can then merge these pull requests.

Thanks!

climbfuji · 2020-06-25T14:55:55Z

@BinLiu-NOAA all regression tests passed on hera with the cleaned up code in these three PRs. Do you want me to commit
RegressionTests_hera.intel.log and Compile_hera.intel.log as part of this PR ?

against official EMC baseline using rt.conf

rt_hera_intel.log
RegressionTests_hera.intel.log
Compile_hera.intel.log

on hera.intel using rt_hwrf_physics.conf: first create temporary baseline, then verify against it

rt_hera_intel_hwrf_physic_create.log
rt_hera_intel_hwrf_physic_verify.log

BinLiu-NOAA · 2020-06-25T16:28:17Z

@climbfuji Please feel free to commit in these log files as you see fit. Thanks!

climbfuji · 2020-06-25T16:41:34Z

@climbfuji Please feel free to commit in these log files as you see fit. Thanks!

Done - are we ready to commit?

BinLiu-NOAA

Ready to merge after the fv3atm level PR goes into support/HAFS.

climbfuji · 2020-06-26T14:56:34Z

@BinLiu-NOAA ufs-weather-model is ready, please check again. Thanks!

BinLiu-NOAA

Looks good. Ready to merge. Thanks!

climbfuji and others added 30 commits April 1, 2020 14:43

Update .gitmodules and submodule pointer for fv3atm for code review a…

fefc91d

…nd testing

Add regression test for HWRF SAS shallow+deep convection

4a3c418

Update .gitmodules and add CODEOWNERS for HWRF physics development

e4ebb21

Update submodule pointer for fv3atm

e0e1422

add HWRF_PBL test to rt_ccpp_hafs.conf (no changes in SDF or other ru…

cb6c3e2

…n configuration required other than one namelist value - hurr_pbl = T)

add non-default value of moninq_fac for HWRF PBL

9446593

change moninq_fac for HWRF_PBL namelist to have a value of -1.0 (afte…

a2095c5

…r consulting with Weiguo Wang)

add HURR_PBL and MONINQ_FAC to default_vars.sh, remove separate namel…

2b25606

…ist for HWRF PBL, add test to rt_ccpp_dtc.conf

Update .gitmodules and submodule pointer for fv3atm for code review a…

caaecf9

…nd testing; add README_HWRF_PHYSICS.txt

Update submodule pointer for fv3atm

b112926

Correct regression test baseline (control) directories for tests fv3_…

a478414

…ccpp_regional_c768_FA_update_moist and fv3_ccpp_regional_c768_HWRF_PBL

Avoid using non-uniform block sizes in regression tests fv3_(ccpp_)st…

f8b82a3

…retched_nest and fv3_(ccpp_)regional_c768

Update submodule pointer for fv3atm

0db8818

tests/fv3_conf/ccpp_regional_FA_run.IN: use correct input directory t…

91be9ea

…o set up the tests

Revert change to .gitmodules and update submodule pointer for fv3atm

3e5fc5e

Merge pull request ufs-community#35 from climbfuji/dtc-hwrf-physics-a…

228dda8

…dd-moninedmf dtc/hwrf-physics: combined version of HAFS/GFS moninedmf scheme (hybrid EDMF PBL)

Update .gitmodules and submodule pointer for fv3atm for code review a…

c28c096

…nd testing

initialize HWRF_RRTMG branch

be78a42

add FA+HRRTMG configuration

6d1cf9f

activate iovr_lw=4 for exponential cloud overlapping method

27bd242

enable iovr_lw only

ae442c5

update HWRF RRTMG configuration

10d712e

Rename new HWRF RRTMG files for a little more consistency, add tests …

649fa6a

…to rt.conf

Produce diagnostic output from ccpp_regional_c768_FA* tests for the f…

f795c4f

…irst three hours, not just the first one

tests/tests/fv3_ccpp_regional_c768_FA_HWRF_RRTMG: bugfix, use correct…

703c4d9

… CNTL_DIR

Update README_HWRF_PHYSICS.txt

fbcb253

Final cleanup work for new FA HWRF RRTMG tests - combine regression t…

b77b4ab

…est namelist templates and run scripts, use own HWRF regression test baseline

Revert change of .gitmodules and update submodule pointer for fv3atm

a8f0363

Merge pull request ufs-community#36 from climbfuji/dtc_hwrf-physics_a…

61b9443

…dd_rrtmg dtc/hwrf-physics: HWRF RRTMG (based on ufs-community#30)

Merge branch 'hafs_sas_for_develop' of https://github.com/climbfuji/u…

997147c

…fs-weather-model into merge_hwrf-sasas_into_dtc_hwrf-physics

This was referenced Jun 19, 2020

Update support/HAFS from NCAR dtc/hwrf-physics 2020/06/19 hafs-community/fv3atm#5

Merged

Update support/HAFS from NCAR dtc/hwrf-physics 2020/06/19 hafs-community/ccpp-physics#2

Merged

climbfuji marked this pull request as ready for review June 19, 2020 15:26

climbfuji requested review from BinLiu-NOAA, mzhangw and ligiabernardet June 19, 2020 15:26

mzhangw previously approved these changes Jun 19, 2020

View reviewed changes

ligiabernardet previously approved these changes Jun 19, 2020

View reviewed changes

climbfuji added 2 commits June 19, 2020 15:20

Add note about location of HAFS input data to several regression test…

b6c3f5c

… setup scripts

Revert baseline change in tests/rt.sh

dadbb0c

climbfuji dismissed stale reviews from ligiabernardet and mzhangw via dadbb0c June 19, 2020 21:21

Cleanup unnecessary regression test configurations

348af8e

climbfuji force-pushed the update_hafs_from_dtc_hwrf_physics_20200619 branch from 47cc1b1 to 348af8e Compare June 25, 2020 03:00

Update submodule pointer for fv3atm

17feaf4

BinLiu-NOAA mentioned this pull request Jun 25, 2020

Merge HWRF CCPP physics into HAFS NOAA-EMC/HAFS#57

Merged

Update regression test logs for hera.intel

f5f6b39

BinLiu-NOAA previously approved these changes Jun 26, 2020

View reviewed changes

Revert change to .gitmodules and update submodule pointer for fv3atm

30c7b81

climbfuji dismissed BinLiu-NOAA’s stale review via 30c7b81 June 26, 2020 14:55

BinLiu-NOAA approved these changes Jun 26, 2020

View reviewed changes

climbfuji merged commit 16f6559 into hafs-community:support/HAFS Jun 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update support/HAFS from NCAR dtc/hwrf-physics 2020/06/19 #5

Update support/HAFS from NCAR dtc/hwrf-physics 2020/06/19 #5

climbfuji commented Jun 19, 2020 •

edited

Loading

mzhangw left a comment

climbfuji commented Jun 19, 2020

climbfuji commented Jun 19, 2020

climbfuji commented Jun 19, 2020

BinLiu-NOAA commented Jun 19, 2020

climbfuji commented Jun 25, 2020

BinLiu-NOAA commented Jun 25, 2020

climbfuji commented Jun 25, 2020

BinLiu-NOAA left a comment

climbfuji commented Jun 26, 2020

BinLiu-NOAA left a comment

Update support/HAFS from NCAR dtc/hwrf-physics 2020/06/19 #5

Update support/HAFS from NCAR dtc/hwrf-physics 2020/06/19 #5

Conversation

climbfuji commented Jun 19, 2020 • edited Loading

mzhangw left a comment

Choose a reason for hiding this comment

climbfuji commented Jun 19, 2020

climbfuji commented Jun 19, 2020

climbfuji commented Jun 19, 2020

BinLiu-NOAA commented Jun 19, 2020

climbfuji commented Jun 25, 2020

BinLiu-NOAA commented Jun 25, 2020

climbfuji commented Jun 25, 2020

BinLiu-NOAA left a comment

Choose a reason for hiding this comment

climbfuji commented Jun 26, 2020

BinLiu-NOAA left a comment

Choose a reason for hiding this comment

climbfuji commented Jun 19, 2020 •

edited

Loading