image.cpp All Images filter missing entries

[BaconCatBug]

The image.cpp source file has the All images filter but it's missing entries, the most egregious being it only shows .jpg and not .jpeg, while clicking down to JPEG Images shows them.

[haganbmj]

Whoops, I basically abandoned this project as Magic kind of died to me.
I see you made a fix over in your own fork.
https://github.com/haganbmj/MagicSetEditor2/compare/master...BaconCatBug:MagicSetEditor2:master?w=1

I'll see about incorporating that and sorting out if there are other missing entries.

[BaconCatBug]

No worries, actual MTG is dead to me too, I just got on a kick of making custom cards. :) The fork I made basically fixed the extensions issue, and gave the option to go up to 400% for internal image size (as pointless as that is, it's nice to have the option).

I could not for the life of me get it to compile as a static binary though, only the dynamically linked compilation worked for me, which is why I've not pushed any builds onto my own fork. That's why the Cmake file is kind of butchered, so don't actually merge anything, lol. The only changes are in src/gui/value/image.cpp and src/gui/preferences_window.cpp

[haganbmj]

The preferences input boxes actually support typing in values as a note, so 400% was doable before by just keying it in. Not a bad convenience though to add it to the dropdown.

[BaconCatBug]

Oh, I had no idea you could just type it in. Don't I feel silly now 😜. Do you have any suggestions on getting it to compile statically? I tried with vcpkg to install the appropriate libraries but as I had to do it in a windows vm it was a pain and I had no luck cross compiling on Linux.

…

On Tue 13 Feb 2024, 2:06 AM Brendan Hagan, ***@***.***> wrote: The preferences input boxes actually support typing in values as a note, so 400% was doable before by just keying it in. Not a bad convenience though to add it to the dropdown. image.png (view on web) <https://github.com/haganbmj/MagicSetEditor2/assets/15820761/493df894-71d0-4c40-a7f1-edb42af1273c> — Reply to this email directly, view it on GitHub <#62 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABFLTC5XC43GTDXUOJPHQ63YTLDDJAVCNFSM6AAAAABANAJHN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBQGIZTCNRZGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[haganbmj]

I think I had to specifically install static versions of the 32/64 bit libraries using vcpkg install wxwidgets:x86-windows-static for example. The readme on this repo says to specify x32, but my vcpkg directory is all x86 so not sure which I had to use in the commands - it's been quite a while.

I know Linux has been a pain in the past, not sure if anyone has really gotten it working natively there without crashes or font rendering issues. I haven't dug into cross compilation.