chore: update node in crud-web-apps from 12 to 16 (kubeflow#7637)

* upgrade node from 12 to 16 Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com> * replace cypress with playwright for e2e tests in jupyter Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com> * update base image for node Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com> * update build scripts for tensorboard Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com> * update build scripts for jupyter Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com> --------- Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com>
hahahannes · Nov 26, 2024 · 78969ee · 78969ee
1 parent 255af21
commit 78969ee
Show file tree

Hide file tree

Showing 79 changed files with 140,331 additions and 65,240 deletions.
diff --git a/.github/workflows/centraldb_angular_frontend_test.yaml b/.github/workflows/centraldb_angular_frontend_test.yaml
@@ -15,7 +15,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version: 12
+          node-version: 16
 
       - name: Check frontend code formatting
         run: |
@@ -37,7 +37,7 @@ jobs:
         uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 12
+          node-version: 16
       - name: Install Kubeflow common library dependecies
         run: |
           cd components/crud-web-apps/common/frontend/kubeflow-common-lib
@@ -53,14 +53,14 @@ jobs:
 
   run-ui-tests:
     name: UI tests in chrome and firefox
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
     steps:
       - name: Checkout
         uses: actions/checkout@v3
-      - name: Setup node version to 12
+      - name: Setup node version to 16
         uses: actions/setup-node@v3
         with:
-          node-version: 12
+          node-version: 16
 
       - name: Install KinD
         run: ./components/testing/gh-actions/install_kind.sh

diff --git a/.github/workflows/common_frontend_tests.yaml b/.github/workflows/common_frontend_tests.yaml
@@ -16,7 +16,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version: 12
+          node-version: 16
 
       - name: Check frontend code formatting
         run: |
@@ -35,10 +35,10 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v3
-      - name: Setup node version to 12
+      - name: Setup node version to 16
         uses: actions/setup-node@v3
         with:
-          node-version: 12
+          node-version: 16
 
       - name: Install Kubeflow common library dependecies
         run: |

diff --git a/.github/workflows/jwa_frontend_tests.yaml b/.github/workflows/jwa_frontend_tests.yaml
@@ -16,7 +16,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version: 12
+          node-version: 16
 
       - name: Check frontend formatting
         run: |
@@ -36,10 +36,10 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v3
-      - name: Setup node version to 12
+      - name: Setup node version to 16
         uses: actions/setup-node@v3
         with:
-          node-version: 12
+          node-version: 16
 
       - name: Install Kubeflow common library dependecies
         run: |
@@ -58,15 +58,15 @@ jobs:
           npm run test:prod
 
   run-ui-tests:
-    name: UI tests with Cypress
+    name: UI tests with Playwright
     runs-on: ubuntu-20.04
     steps:
       - name: Checkout
         uses: actions/checkout@v3
-      - name: Setup node version to 12
+      - name: Setup node version to 16
         uses: actions/setup-node@v3
         with:
-          node-version: 12
+          node-version: 16
 
       - name: Install Kubeflow common library dependecies
         run: |
@@ -79,8 +79,9 @@ jobs:
           cd components/crud-web-apps/jupyter/frontend
           npm i
           npm link kubeflow
-      - name: Serve UI & run Cypress tests in Chrome and Firefox
+      - name: Serve UI & run Playwright tests in Chrome and Firefox
         run: |
           cd components/crud-web-apps/jupyter/frontend
-          npm run serve & npx wait-on http://localhost:4200
+          npm run serve > serve.log 2>&1 & npx wait-on http://localhost:4200
+          npx playwright install
           npm run ui-test-ci-all
diff --git a/.github/workflows/notebook_controller_unit_test.yaml b/.github/workflows/notebook_controller_unit_test.yaml
@@ -20,4 +20,4 @@ jobs:
     - name: Run unit tests
       run: |
         cd components/notebook-controller
-        make test
+        make test
diff --git a/.github/workflows/pvcviewer_controller_unit_test.yaml b/.github/workflows/pvcviewer_controller_unit_test.yaml
@@ -20,4 +20,4 @@ jobs:
     - name: Run unit tests
       run: |
         cd components/pvcviewer-controller
-        make test
+        make test
diff --git a/.github/workflows/twa_frontend_tests.yaml b/.github/workflows/twa_frontend_tests.yaml
@@ -16,7 +16,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version: 12
+          node-version: 16
 
       - name: Format tensorboards web app
         run: |
@@ -36,10 +36,10 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v3
-      - name: Setup node version to 12
+      - name: Setup node version to 16
         uses: actions/setup-node@v3
         with:
-          node-version: 12
+          node-version: 16
 
       - name: Install Kubeflow common library dependecies
         run: |
@@ -63,10 +63,10 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v3
-      - name: Setup node version to 12
+      - name: Setup node version to 16
         uses: actions/setup-node@v3
         with:
-          node-version: 12
+          node-version: 16
 
       - name: Install Kubeflow common library dependecies
         run: |
@@ -82,5 +82,5 @@ jobs:
       - name: Serve UI & run Cypress tests in Chrome and Firefox
         run: |
           cd components/crud-web-apps/tensorboards/frontend
-          npm run serve & npx wait-on http://localhost:4200
+          npm run serve > serve.log 2>&1 & npx wait-on http://localhost:4200
           npm run ui-test-ci-all
diff --git a/.github/workflows/vwa_frontend_tests.yaml b/.github/workflows/vwa_frontend_tests.yaml
@@ -16,7 +16,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version: 12
+          node-version: 16
 
       - name: Check frontend code formatting
         run: |
@@ -35,10 +35,10 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v3
-      - name: Setup node version to 12
+      - name: Setup node version to 16
         uses: actions/setup-node@v3
         with:
-          node-version: 12
+          node-version: 16
 
       - name: Install Kubeflow common library dependecies
         run: |
@@ -62,10 +62,10 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v3
-      - name: Setup node version to 12
+      - name: Setup node version to 16
         uses: actions/setup-node@v3
         with:
-          node-version: 12
+          node-version: 16
 
       - name: Install Kubeflow common library dependecies
         run: |
@@ -93,10 +93,10 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v3
-      - name: Setup node version to 12
+      - name: Setup node version to 16
         uses: actions/setup-node@v3
         with:
-          node-version: 12
+          node-version: 16
 
       - name: Install Kubeflow common library dependecies
         run: |

diff --git a/components/centraldashboard-angular/Dockerfile b/components/centraldashboard-angular/Dockerfile
@@ -1,5 +1,5 @@
 # --- Build the backend ---
-FROM node:12-buster-slim as backend
+FROM node:16.20.2-bullseye as backend
 
 COPY ./centraldashboard-angular/backend/ ./src
 WORKDIR /src
@@ -9,7 +9,7 @@ RUN npm ci && \
     npm prune --production
 
 # --- Build the frontend kubeflow library ---
-FROM node:12-buster-slim as frontend-kubeflow-lib
+FROM node:16.20.2-bullseye as frontend-kubeflow-lib
 
 WORKDIR /src
 
@@ -24,7 +24,7 @@ COPY ./crud-web-apps/common/frontend/kubeflow-common-lib/tsconfig.json .
 RUN npm run build
 
 # --- Build the frontend ---
-FROM node:12-buster-slim as frontend
+FROM node:16.20.2-bullseye as frontend
 
 ARG kubeflowversion
 ENV BUILD_VERSION=$kubeflowversion
@@ -39,7 +39,7 @@ COPY --from=frontend-kubeflow-lib /src/dist/kubeflow/ ./node_modules/kubeflow/
 RUN npm run build -- --output-path=./dist/default --configuration=production
 
 # Step 2: Packages assets for serving
-FROM node:12.22.12-alpine AS serve
+FROM node:16.20.2-alpine AS serve
 
 ENV NODE_ENV=production
 WORKDIR /app
@@ -50,4 +50,3 @@ COPY --from=frontend /src/dist/default/assets/dashboard_lib.bundle.js.map ./dist
 
 EXPOSE 8082
 ENTRYPOINT ["npm", "start"]
-