forked from WebKit/WebKit
-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[LFC][IFC] Inline boxes with collapsible content only should not be c…
…onsidered opaque bidi items https://bugs.webkit.org/show_bug.cgi?id=235447 Reviewed by Antti Koivisto. Source/WebCore: We don't normally submit inline boxes with content to ubidi re-ordering since their content drives the visual position unless they are empty. While empty inline boxes do not usually produce visual artifacts (except ones with decoration) they still need to be able to answer "bounding box" type of questions. So in order to have geometry generated for inline boxes, they either 1, need to have some content so that while processing their content, we also compute their geometries 2, have to participate in ubidi's visual re-ordering so that they show up in the visual list (which is the input to the display box create function) This patch treats inline boxes with fully collapsible content empty so that they fall into group #2. * layout/formattingContexts/inline/InlineItemsBuilder.cpp: (WebCore::Layout::InlineItemsBuilder::breakAndComputeBidiLevels): LayoutTests: * TestExpectations: Canonical link: https://commits.webkit.org/246272@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
1 parent
ce1789d
commit 4a272d5
Showing
4 changed files
with
31 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters