Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactor of Builders/Builder.py #273

Merged
merged 12 commits into from
Oct 9, 2023
Merged

Small refactor of Builders/Builder.py #273

merged 12 commits into from
Oct 9, 2023

Conversation

jurgenwigg
Copy link
Contributor

Things changed:

  • Changed name from _BuilderState to BuilderState.
  • Removed object inheritance (it's unnecessary for python3)
  • Added unit tests for BuilderState
  • Added tox-based CI

@jurgenwigg jurgenwigg changed the title Small refactor of Builders/Builder.py [WIP] Small refactor of Builders/Builder.py Sep 29, 2023
@jurgenwigg jurgenwigg changed the title [WIP] Small refactor of Builders/Builder.py Small refactor of Builders/Builder.py Oct 2, 2023
@waddlesplash waddlesplash merged commit 007d868 into haikuports:master Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pulkomandy pulkomandy pulkomandy left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jurgenwigg @pulkomandy @waddlesplash