[batch] fix retry of clone #8190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want the function to exit in error if any step fails. I achieve this by starting a sub-shell and setting -e inside that sub shell. That causes the sub-shell to exit if any individual command fails. Previously, the `git clone` could fail but `clone` would still return exit code zero.
jigold
approved these changes
Feb 28, 2020
|
This is still not working. https://ci.hail.is/batches/19141 |
|
OK, so. The issue seems to be that docker shuts down a connection when an invalid packet is received. moby/libnetwork#1090 Why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want the function to exit in error if any step fails. I achieve this by
starting a sub-shell and setting -e inside that sub shell. That causes the
sub-shell to exit if any individual command fails.
Previously, the
git clonecould fail butclonewould still return exit codezero.