Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UPD] web_dialog_size: reduce rpc call to get config #1

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from
Open

[UPD] web_dialog_size: reduce rpc call to get config #1

wants to merge 1 commit into from

Conversation

hailangvn2023
Copy link
Owner

No description provided.

@hailangvn
[UPD] web_dialog_size: reduce rpc call to get config
3484abf 
After installing web_dialog_size and setup its parameter, there's
a slight delay where we can see the modal at its normal size and then
after a rpc to ir.config_parameter:get_web_dialog_size_config() the
modal is maximized.

This commit is to set a session value then use it to set initial dialog
size upfront without delay.
@hailangvn2023 hailangvn2023 force-pushed the 15.0-imp-web_dialog_size branch from 956e887 to 3484abf Compare June 7, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilshamerlinck nilshamerlinck nilshamerlinck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hailangvn2023 @nilshamerlinck @hailangvn