Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trusted publishing #350

Merged
merged 1 commit into from
May 9, 2023
Merged

trusted publishing #350

merged 1 commit into from
May 9, 2023

Conversation

malmans2
Copy link
Contributor

@malmans2 malmans2 commented May 5, 2023

I just learned about trusted publishing, a new feature of PyPI.
All the advantage of using it are explained here: https://docs.pypi.org/trusted-publishers/

Hopefully I got everything right, the only way to test it is to issue a new release...

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #350 (59dbf1d) into main (3858c33) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #350   +/-   ##
=======================================
  Coverage   94.75%   94.75%           
=======================================
  Files           9        9           
  Lines        3944     3944           
  Branches      859      859           
=======================================
  Hits         3737     3737           
  Misses        131      131           
  Partials       76       76           
Flag Coverage Δ
unittests 94.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Mikejmnez
Copy link
Collaborator

@malmans2 looks good. Does this need anything else? I need to do some work on oceanspy that I would like to include in a new release (hopefully this week), so I guess there is no rush with this...

@malmans2
Copy link
Contributor Author

malmans2 commented May 9, 2023

It should be good to go.
I'm going to merge this, we just need to double check that everything is working properly when we issue the next release.

@malmans2 malmans2 merged commit 20c1a5d into main May 9, 2023
@malmans2 malmans2 deleted the trusted-publishing branch May 9, 2023 09:25
Mikejmnez pushed a commit to Mikejmnez/oceanspy that referenced this pull request May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants