Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test and support python 3.11 #351

Merged
merged 4 commits into from
May 19, 2023
Merged

test and support python 3.11 #351

merged 4 commits into from
May 19, 2023

Conversation

malmans2
Copy link
Contributor

@malmans2 malmans2 commented May 5, 2023

I think we should be able to support python 3.11 now.
Let's see if the CI is happy with 3.11.

@malmans2
Copy link
Contributor Author

malmans2 commented May 5, 2023

doh! Looks like the problem is matplotlib that is pinned to a quite old version.
I guess we'll have to wait until #269 is resolved (cc @MaceKuailv that is working on #348).

@MaceKuailv
Copy link
Collaborator

The issue #269 is actually resolved. It is a kind of confusing situation. The pin we have now is for issue #349. We can relax the pin from "<3.5.2" to "<3.6.1". But to completely unpin, we need to work on issue 349, which is not going to be easy to do...

@MaceKuailv
Copy link
Collaborator

Seems like the error message is not related to any tests. It is something related to the building process.

 Error: Failed to execute ["/home/runner/micromamba-bin/micromamba create -n oceanspy_test -y --log-level warning \"python=3.11\" -f /home/runner/work/oceanspy/oceanspy/ci/environment.yml"]: Error: The process '/home/runner/micromamba-bin/micromamba' failed with exit code 1

I am about to do some ci things for my package as well, I would love to work on this PR with you.

@malmans2
Copy link
Contributor Author

malmans2 commented May 5, 2023

If you look a bit further up, you'll see:

  error    libmamba Could not solve for environment specs
      The following packages are incompatible
      ├─ matplotlib <3.5.3  is installable with the potential options

Anyways, let's see if 3.6 is good enough. I'm going to merge main into this branch.

@malmans2
Copy link
Contributor Author

malmans2 commented May 5, 2023

ohh I see, you did not change the pin yet.
No rush, I'll leave this open and we'll try again 3.11 when the issue with matplotlib is sorted out.
I'm moving this to draft PR.

@malmans2 malmans2 marked this pull request as draft May 5, 2023 16:09
@Mikejmnez
Copy link
Collaborator

@malmans2 I changed the pin to matplotlib in the last PR to 3.6.0, in case you want to give it another try to this PR

@malmans2 malmans2 temporarily deployed to pypi May 18, 2023 11:36 — with GitHub Actions Inactive
@malmans2
Copy link
Contributor Author

Main merged here. Let's see how it goes...

@Mikejmnez
Copy link
Collaborator

Same as before... Good to know though. I'm going take a look at #349 today so hopefully there is some quick fix

@Mikejmnez
Copy link
Collaborator

Matplotlib is now unpinned via PR #355

@malmans2 malmans2 temporarily deployed to pypi May 19, 2023 18:32 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #351 (8e8c803) into main (fb4cc96) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #351   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files           9        9           
  Lines        3932     3932           
  Branches      858      924   +66     
=======================================
  Hits         3727     3727           
  Misses        129      129           
  Partials       76       76           
Flag Coverage Δ
unittests 94.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@malmans2 malmans2 marked this pull request as ready for review May 19, 2023 18:45
@malmans2
Copy link
Contributor Author

Green lights, merging!

@malmans2 malmans2 merged commit 3bfaf18 into main May 19, 2023
@malmans2 malmans2 deleted the py311 branch May 19, 2023 18:45
@Mikejmnez
Copy link
Collaborator

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants