-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test and support python 3.11 #351
Conversation
doh! Looks like the problem is matplotlib that is pinned to a quite old version. |
Seems like the error message is not related to any tests. It is something related to the building process.
I am about to do some ci things for my package as well, I would love to work on this PR with you. |
If you look a bit further up, you'll see:
Anyways, let's see if 3.6 is good enough. I'm going to merge main into this branch. |
ohh I see, you did not change the pin yet. |
@malmans2 I changed the pin to matplotlib in the last PR to 3.6.0, in case you want to give it another try to this PR |
Main merged here. Let's see how it goes... |
Same as before... Good to know though. I'm going take a look at #349 today so hopefully there is some quick fix |
Matplotlib is now unpinned via PR #355 |
Codecov Report
@@ Coverage Diff @@
## main #351 +/- ##
=======================================
Coverage 94.78% 94.78%
=======================================
Files 9 9
Lines 3932 3932
Branches 858 924 +66
=======================================
Hits 3727 3727
Misses 129 129
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Green lights, merging! |
Awesome! |
I think we should be able to support python 3.11 now.
Let's see if the CI is happy with 3.11.