Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a file-level error when failed to checkout file #2692

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Conversation

feiniks
Copy link
Contributor

@feiniks feiniks commented Jul 17, 2023

No description provided.

// Record a file-level sync error when failed to checkout file.
if (rc == FETCH_CHECKOUT_FAILED) {
send_file_sync_error_notification (repo_id, repo_name, de->name,
SYNC_ERROR_ID_WRITE_LOCAL_DATA);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SYNC_ERROR_ID_WRITE_LOCAL_DATA 是一个现有的错误 ID,而且是一个资料库级别的错误。应该新定义一个文件级别的错误,专门用于导出文件失败。

@killing killing merged commit ed64098 into master Jul 20, 2023
@killing killing deleted the checkout_file branch July 20, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants