Add block missing sync error #2694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killing
reviewed
Jul 21, 2023
daemon/http-tx-mgr.c
Outdated
| @@ -1101,6 +1102,8 @@ http_error_to_http_task_error (int status) | |||
| return SYNC_ERROR_ID_SERVER_REPO_CORRUPT; | |||
| else if (status == HTTP_REPO_TOO_LARGE || status == HTTP_REQUEST_TIME_OUT) | |||
| return SYNC_ERROR_ID_LIBRARY_TOO_LARGE; | |||
| else if (status == HTTP_BLOCK_MISSING) | |||
| return SYNC_ERROR_ID_BLOCK_MISSING; | |||
There was a problem hiding this comment.
想了一下，为了便于问题排查和处理，服务器端应该一次性把所有没有上传完整的文件名在 reponse body 中以 JSON 格式返回。客户端在日志中打印一下。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.