Only record a file-level error,don't send notification #2701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killing
reviewed
Aug 28, 2023
daemon/repo-mgr.c
Outdated
| @@ -5201,9 +5201,10 @@ download_files_http (const char *repo_id, | |||
|
|
|||
| // Record a file-level sync error when failed to checkout file. | |||
| if (rc == FETCH_CHECKOUT_FAILED) { | |||
| send_file_sync_error_notification (repo_id, repo_name, de->name, | |||
| SYNC_ERROR_ID_CHECKOUT_FILE); | |||
| seaf_repo_manager_record_sync_error (repo_id, repo_name, de->name, | |||
There was a problem hiding this comment.
这个应该给每个 repo 记录一个内存中的状态，是否发送过 checkout 失败的警告。如果没发送过就发送一次；重启之后这个状态重置。
完全不发送也不好。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.