Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ebiten: SetScreenClearedEveryFrame(false) unexpectedly disables vsync Metal (and maybe DirectX) #2520

Closed
1 of 10 tasks
hajimehoshi opened this issue Jan 2, 2023 · 0 comments
Closed
1 of 10 tasks

ebiten: SetScreenClearedEveryFrame(false) unexpectedly disables vsync Metal (and maybe DirectX) #2520

hajimehoshi opened this issue Jan 2, 2023 · 0 comments
Labels
bug os:macos
Milestone
v2.5.0

Comments

@hajimehoshi
Copy link
Owner

Ebitengine Version

4d270de

Operating System

  • Windows
  • macOS
  • Linux
  • FreeBSD
  • OpenBSD
  • Android
  • iOS
  • Nintendo Switch
  • Xbox
  • Web Browsers

Go Version (go version)

go version go1.19.4 darwin/amd64

What steps will reproduce the problem?

Run the program at #2517 (comment) but with RunGame instead of RunGameWithOptions

What is the expected result?

Vsync works

What happens instead?

Vsync doesn't work, as rendering onto the final framebuffer doesn't happen

Anything else you feel useful to add?

No response
@hajimehoshi hajimehoshi added the bug label Jan 2, 2023
@hajimehoshi hajimehoshi added this to the v2.5.0 milestone Jan 2, 2023
hajimehoshi referenced this issue Jan 2, 2023
@hajimehoshi
internal/ui: disable the optimization to skip rendering offscreen
a049acd 
This caused some issues in various environments. Until we find a good
solution, let's disable this.

Updates #2341
Updates #2342
Closes #2518
hajimehoshi added a commit that referenced this issue Jan 3, 2023
@hajimehoshi
internal/ui: re-enable skipping to render the final screen when possible
7418576 
With Metal, nextDrawable could return immediately when a command buffer
is empty. To avoid high CPU usage, this change adds a slight sleep in
this case.

With DirectX, Present waits for a while even though nothing is updated,
then that's fine.

Updates #2341
Updates #2342
Updates #2520
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug os:macos
Projects
None yet
Milestone
v2.5.0
Development

No branches or pull requests
1 participant
@hajimehoshi