Skip to content

Commit

Permalink
npm up && downgraded react-scripts:
Browse files Browse the repository at this point in the history
- We had a major bug since a while back where we ran out of heap memory when building and/or starting the project. I boiled it down to be caused by a bug in Bable 7.7.4, which itself isn't a dependency, but react-scripts depend on it. The bug is fixed in 7.7.7, but I couldn't easily upgrade the package. We'll have to wait for a new release of react-scripts (>3.3.0) and see if they've bumped Babel to >=7.7.7.
- Note that this only happens in bigger projects when the source map is being build. Admin remains unaffected, even tough it's on 3.3.0.
  • Loading branch information
jacobwod committed Jan 9, 2020
1 parent 4b1fd14 commit f9a502d
Show file tree
Hide file tree
Showing 5 changed files with 1,466 additions and 1,330 deletions.
1 change: 0 additions & 1 deletion _config.yml

This file was deleted.

12 changes: 6 additions & 6 deletions new-admin/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions new-admin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@
"ol": "^5.3.3",
"proj4": "^2.6.0",
"react": "^16.12.0",
"react-color": "^2.17.3",
"react-color": "^2.18.0",
"react-dom": "^16.12.0",
"react-modal": "^3.11.1",
"react-scripts": "^3.3.0",
"react-smooth-dnd": "^0.11.1",
"typescript": "^3.7.3",
"typescript": "^3.7.4",
"x2js": "^3.4.0"
},
"scripts": {
Expand Down
Loading

1 comment on commit f9a502d

@jacobwod
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to reference the issue in commit message: facebook/create-react-app#8096.

Please sign in to comment.