Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log4js setup in Backend #894

Closed
jacobwod opened this issue Nov 5, 2021 · 0 comments
Closed

Fix log4js setup in Backend #894

jacobwod opened this issue Nov 5, 2021 · 0 comments
Assignees
@jacobwod
Labels
bug module:backend MapService stuff
Milestone
3.8

Comments

@jacobwod
Copy link
Member

jacobwod commented Nov 5, 2021

Currently some log messages aren't logged in the proper way. This is because the log4js.configure() happens inside server.js, but after log4js has been used in some imports. So other files that do use the log4js singleton do work but they aren't configured in the same way as the following log messages (so they end up somewhere else than where we'd want them to be).
@jacobwod jacobwod added bug module:backend MapService stuff labels Nov 5, 2021
@jacobwod jacobwod added this to the 3.8 milestone Nov 5, 2021
@jacobwod jacobwod self-assigned this Nov 5, 2021
jacobwod added a commit that referenced this issue Nov 5, 2021
@jacobwod
Ensure that log4js is correctly configured for all loggers, closes #894:
d4f3d10 
- Moved the configuration of log4js to a helper that is imported very early, so we can be confident that it's correctly setup.
- Fixed some ESlint errors.
@jacobwod jacobwod closed this as completed Nov 5, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobwod jacobwod

Labels
bug module:backend MapService stuff
Projects
None yet
Milestone
3.8
Development

No branches or pull requests
1 participant
@jacobwod