Feature/1171 plugin history #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e issue to also include the UI part soon.
- This is just a POC, will need polishing - Only BaseWindowPlugins are done. DialogWindow remain and will crash if invoked currently. - I needed to rename the import of Map from OL, else I got a conflict with JS's built-in Map object.
…well: - The following remains: - finding a good icon and a good placement for this FAB on small screens - deciding whether we use the FAB or some other element (Breadcrumbs/List/?) on desktop. I think it would make sense to have a small menu that's always visible, rather then hidden inside a FAB, when there's sufficient screen estate.
…ugins: - Added an option to Admin UI to control if this will show: showRecentlyUsedPlugins - Changed icon to something more correct, hopefully. Feel free to comment/change. - Added a flag that always shows the name of the plugins in a tooltip. Not sure if I like it or not, but it should make it easier for the user. I'm open to discussing this too,. Added auto-close of the SpeedDial upon click - feels more correct this way.
jacobwod
added
module:client/core
Hallbergs
reviewed
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.