Feature/1338 anchor bug fix

[OlofSvahnVbg]

This PR refers to this issue: Oversiktsplan - Url link missing from Anchor View (Dela) #1338

closes #1338

[jacobwod]

Can you please check if the behaviour is still correct when enableAppStateInHash is enabled? To enable it, just add the query string param enableAppStateInHash, e.g. https://karta.halmstad.se/?enableAppStateInHash.

Do the live hash update and the Anchor plugin (both its initial value and live updating of the input in AnchorView) still work?

[OlofSvahnVbg]

So I tried https://oversiktsplan-utv.varberg.se/?/enableAppStateInHash and the anchor gets set the same way as it does without the query, and the live update seems to work aswell (if you mean registering changes like moving the map, zooming etc.)

[jacobwod]

That sound good, thanks for the test. We'll take a proper look next week!

[Hallbergs]

anchor is not defined here and won't be of type string. When i test your implementation, the view results in an empty field:

(It renders an empty field if you have the anchor plugin enabled at start).

I think this issue could be resolved with:

async componentDidMount() {
    const a = await this.props.model.getAnchor();
    this.setState({ anchor: a });
    // Subscribe to changes to anchor URL caused by other components. This ensure
    // that we have a live update of the anchor whether user does anything in the map.
    this.props.globalObserver.subscribe(
      "core.mapUpdated",
      ({ url, source }) => {
        this.setState({
          anchor: this.appendCleanModeIfActive(url),
        });
      }
    );
  }

Maybe you could test that and see if it works for you as well? The strange thing is that the original implementation also works for me...

[OlofSvahnVbg]

Interesting. I tried having the dela-window opened at start aswell, and the link does appear. But I'll try your fix :)

[OlofSvahnVbg]

So your codes seems to be working fine. Although, if I scroll while the page is starting the link does not appear.

[jacobwod]

You mean it doesn't get updated?

The componentDidMount part runs only on initial component load. The following updates of anchor string are taken care of elsewhere, please ensure to use the same methodology (await this.props.model.getAnchor()) before calling setState().

[Hallbergs]

Hmm... Seems like getAnchor never resolves in some cases... It's not pretty but this should do the trick:

async componentDidMount() {
    // Subscribe to changes to anchor URL caused by other components. This ensure
    // that we have a live update of the anchor whether user does anything in the map.
    this.props.globalObserver.subscribe(
      "core.mapUpdated",
      ({ url, source }) => {
        this.setState({
          anchor: this.appendCleanModeIfActive(url),
        });
      }
    );
    const a = await this.props.model.getAnchor();
    this.setState({ anchor: a });
  }

(We have to make sure the subscription is made. If getAnchor never resolves, the subscription is never made, and the anchor-url is never updated).

[OlofSvahnVbg]

This works on my end :)