Feature/1374 configurable search options #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new JSON structure in the client for managing and controlling which search functionalities are enabled. The updated structure utilizes an array named `enabledSearchOptions`, including the following options: - matchCase - activeSpatialFilter - wildcardAtStart - searchInVisibleLayers - wildcardAtEnd - enableLabelOnHighlight This approach allows for centralized management of search options, making it easy to enable or disable specific functionalities directly through the admin UI. To ensure these settings always take effect when changed, they are not stored in `localStorage`.
Hallbergs
previously approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Works well!
The code could be refactored though. For example the following is repeated in several places:
onChange={(e) => {
const { checked } = e.target;
this.setState((prevState) => {
const enabledSearchOptions = new Set(
prevState.enabledSearchOptions
);
if (checked) {
enabledSearchOptions.add("searchInVisibleLayers");
} else {
enabledSearchOptions.delete("searchInVisibleLayers");
}
return {
enabledSearchOptions: Array.from(enabledSearchOptions),
};
});
}}Refactor repeated `onChange` logic into a reusable method `handleOnChange`.
# Conflicts: # apps/client/src/components/Search/SearchSettings.js
Hallbergs
previously approved these changes
Sep 2, 2024
There was a problem hiding this comment.
I've merged develop and updated the changelog. Tested with Node backend and seems to work fine. @jacobwod @jesade-vbg @Albinahmetaj @OlofSvahnVbg do you want to test it before merge?
|
Tested it (with Node backend) and it seems to be working! |
Hallbergs
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1374.