Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdown plugin: data-separator does not seem to have a default value. Should it have one? #2832

Closed
dr-leo opened this issue Nov 5, 2020 · 4 comments

Comments

@dr-leo
Copy link

dr-leo commented Nov 5, 2020

Hi,

I am new to this excellent framework and stumbled upon what I consider a bug either in the markdown plugin or the docs or both.

The
docs state the following:

... in the external file: the data-separator attribute defines a regular expression for horizontal slides (defaults
to ^\r?\n---\r?\n$, ...

However, the code example for internal markdown, which does not define data-separator (thus allegedly relying on its default value) places all the text on the same slide.
Likewise, the examples/markdown.html file suggests that there is no default value for data-separator:

<!-- No "extra" slides, since there are no separators defined (so they'll become horizontal rulers) -->
                <section data-markdown>
                    <script type="text/template">
                        A

                        ---

                        B

                        ---

                        C
                    </script>
                </section>

Moreover, if there was a default value defined in the plugin, it should apply to internal MD as well, in which case the docs should make this clear (currently, they suggest that data-separator only influences the parsing of external MD).

@L0ganW
Copy link

L0ganW commented Nov 6, 2020

In other words it dosen't recognize the
Input so it spits an error.

@dr-leo
Copy link
Author

dr-leo commented Nov 6, 2020 via email

@ee0s
Copy link

ee0s commented Nov 24, 2020

I think #2850 is related to this.

@hakimel
Copy link
Owner

hakimel commented Feb 10, 2021

Thanks for reporting. I just pushed a fix for this in #2850 (comment)

@hakimel hakimel closed this as completed Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants