Adding one-sided transitions #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To honor the DRY principle repeating patterns have been factored out. In addition there was an anchor missing in README.md.
Now the transition isn’t any more „per slide“ but „per movement of a slide“. So the slide can disappear in another way than it appeared.
|
This is really great! I'm creating some tests to ensure there's no regression but so far everything is working perfectly. Will merge soon. |
hakimel
added a commit
that referenced
this pull request
May 3, 2015
|
Merged! Should probably also add support for separate in and out background transitions ( |
|
Great! Thanks for coming back on this! |
komita1981
pushed a commit
to komita1981/reveal.js
that referenced
this pull request
Aug 7, 2015
* upstream/master: (82 commits) add bower json hakimel#1067 README: suggest decktape as an alternative for PDF rendering broken <table> html in demo deck `licenses` field is deprecated enabling launching presentation with npm-start Allows to specify PORT from env on multiplex plugin add base option for grunt serve task hakimel#1102 added missing comma on the configuration example 3.1.0 consider lazy loaded iframes when formatting src fix iframe unload in firefox iframe postmesssage api works with lazy loaded iframes sync starts playing new embedded content type check to ensure we don't call media api before media has loaded fix lazy load selector error tweak to iframe lazy load test typo lazy-load iframes only for current slide, unload when hidden lazy loading fallback also considers iframes add test presentation for per-slide transitions, compile css hakimel#1106 ...
|
Would also be great if you could specify different in and out transition speeds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the transition isn’t any more „per slide“ but „per movement of a slide“. So the slide can disappear in a different way than it appeared. This makes a more natural changing of the transition style during a talk.
There is an explanation added to README.md.
(This is my first pull request ever, so please be kind if I made any mistakes.)