Fix case of keyboard shortcuts, add Page Up/Down #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indicate keys in lower-case to avoid confusion. (E.g., the search plugin makes use of Ctrl-Shift-F.) Document PageUp and PageDown.
|
On my keyboard keys are labelled uppercase but when I press them I get lowercase letters...very confusing indeed. 😉 Joking aside, I agree that it actually add clarity, so 👍 from me. |
|
Good catch documenting page up/down. I prefer the alphabet keys in uppercase as on a keyboard though. If you can roll that back I'll merge this in. Thanks! |
lechten
force-pushed
the
fix-shortcut-case
branch
from
e8247ff to
7955e72
Compare
coMnaxtikgi
approved these changes
Nov 23, 2020
coMnaxtikgi
approved these changes
Nov 23, 2020
Comment on lines
-281
to
-291
| 'N , SPACE': 'Next slide', | ||
| 'P': 'Previous slide', | ||
| '← , H': 'Navigate left', | ||
| '→ , L': 'Navigate right', | ||
| '↑ , K': 'Navigate up', | ||
| '↓ , J': 'Navigate down', | ||
| 'n , PageDown , SPACE': 'Next slide', | ||
| 'p , PageUp': 'Previous slide', | ||
| '← , h': 'Navigate left', | ||
| '→ , l': 'Navigate right', | ||
| '↑ , k': 'Navigate up', | ||
| '↓ , j': 'Navigate down', | ||
| 'Home': 'First slide', | ||
| 'End': 'Last slide', | ||
| 'B , .': 'Pause', | ||
| 'F': 'Fullscreen', | ||
| 'ESC, O': 'Slide overview' |
| 'Home': 'First slide', | ||
| 'End': 'Last slide', | ||
| 'B , .': 'Pause', |
coMnaxtikgi
approved these changes
Nov 23, 2020
coMnaxtikgi
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indicate keys in lower-case to avoid confusion.
(E.g., the search plugin makes use of Ctrl-Shift-F.)
Document PageUp and PageDown.