-
-
Notifications
You must be signed in to change notification settings - Fork 16.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data-preload attribute for iframes #2354
Conversation
A couple of interesting things I noticed while working on this change:
|
This is great! Thanks for the commit. Should the console.log() be removed from line 3718? |
Yes, whoops 😳 |
Allows lazy-loaded (i.e. data-src) iframes to be preloaded when they come within the viewDistance, rather than once they're visible.
Pinging @hakimel who reviewed a previous iteration of this PR |
Looks great! Will find time to review and test this soon. No need to ping me btw – I receive notifications for everything in this repo :) |
This has been merged now! I added some tests and made a few smaller changes in d6f0f41 |
Awesome! Any sense of when the next release is going out? |
3.8.0 was just released and includes this update. |
Allows lazy-loaded (i.e. data-src) iframes to be preloaded when they
come within the viewDistance, rather than once they're visible.
Replaces #2353, which was against master rather than dev.