-
-
Notifications
You must be signed in to change notification settings - Fork 16.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reveal.js 4.0.0 #2651
reveal.js 4.0.0 #2651
Conversation
I have created a gulpfile.js with the same tasks of grunt, replaced npm script and finally ad .jshintrc for jshint
I forgot them 😧
I added the same jshint configuration/rules in package.json and I replaced some old function with arrow function to improve legibility
Add RTL support to Controls
Add RTL support to Controls
Hi Hakim, cool progress you're making! Love the auto-animate :-) Also, the slidetransitionend is something that my Appearance plugin can use. Could you also emit an event for fragmenttransitionend? For example, if a user has set a slow css transition for a fragment, and there is a chart in there, then it can hold off to start building the chart columns when the fragment transition is complete. Having a built-in fragmenttransitionend would then make my Transit plugin, currently needed for Appearance, completely obsolete, which is something we talked about earlier. I would prefer that to asking people to keep using it for fragment transitions. |
Thanks @Martinomagnifico! An event for fragment transitions could be useful too. It's not something I'm going to add to 4.0 since I'm trying to wrap that up for release but will consider it for another update. |
I've moved the built plugins from Also the notes plugin is now 100% bundled in a single notes.js file. It used to require loading of an external notes.html HTML file, which led to issues with changing relative paths etc. |
4.0.0 is now merged into master 🚀 If anyone wants to try it out and give feedback I'd really appreciate it: https://github.com/hakimel/reveal.js/releases/tag/4.0.0-rc.1 Release notes are underway and upgrade instructions can be found here https://revealjs.app/upgrading/ |
So far everything works fine for me. Just another small wish: At the end of index.js you are providing a pre 4.x compatiblity layer. Could you add the VERSION attribute so a plugin is not required to do duck typing if it needs special logic for certain versions during its loading time? |
@hakimel this upgrading link works: https://revealjs.com/upgrading/ |
Thanks for testing! @McShelby Great suggestion, @RealCyGuy I switched revealjs.com over the new website today. DNS might still be propagating depending on where you're located though. If anyone wants to contribute to the docs, the repo for is https://github.com/reveal/revealjs.com. |
Hi Hakim, there is something I noticed regarding Themes: The white and black theme react to section(data-background="some other color") when this color is dark or light compared to the main slide background. It's a CSS rule that in those cases sets the font color to a contrasting color. The other Reveal themes do not have such a rule. So if a user sets a very contrasting background in any of the other themes (compared to the main background), the fonts become almost unreadable. The good thing is that the controls do change to a contrasting color. Also, the colors set in the rules in Black and White directly use a Hex color, not a variable. I would suggest adding exposed variable colors like --main-color-opposite, --heading-color-opposite etc., or at least add rules in those themes for dark/light backgrounds. |
@Martinomagnifico Thanks for the feedback! I've made a note to add inverse text colors to the rest of the themes as well and expose them as CSS variables. This isn't something that has changed in version 4.0 so we'll save it for next version. |
reveal.js 4.0.0 is now shipped and available from npm 🚀 Release notes: https://github.com/hakimel/reveal.js/releases/tag/4.0.0 |
reveal.js 4.0.0
想请问一下,关于4.0的npm版本,支持的最低node版本有介绍吗,抱歉实在没有找到... |
I've been hard at work on reveal.js 4.0.0 for a while now and wanted to share the progress so far. It's not ready to merge just yet, but it's getting close.
The main changes in this release are:
slidetransitionend
event.Reveal.add/removeEventListener
->Reveal.on/off
.Reveal.initialize().then( () => console.log( 'ready' ) )
.There are a few breaking changes in this release:
https://github.com/reveal/multiplex
https://github.com/reveal/notes-server
Docs, upgrade instructions and a new revealjs.com will follow when it's ready to merge but hopefully this gives you an idea of what's to come! ✌️