Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

escape parentheses in background image URL #3316

Closed
wants to merge 1 commit into from
Closed

escape parentheses in background image URL #3316

wants to merge 1 commit into from

Conversation

waldenn
Copy link

@waldenn waldenn commented Nov 5, 2022

This fixes the issue I posted earlier today: #3315

@waldenn
Copy link
Author

waldenn commented Nov 6, 2022

There could be some other characters which need to be encoded (single/double quotes?)

@waldenn waldenn mentioned this pull request Feb 11, 2023
Open
@Martinomagnifico
Copy link
Collaborator

Thanks for the PR. Your mention that there could be other characters led to the correct fix that was pushed earlier today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waldenn @Martinomagnifico