Correctly strip leading white-space from markdown #3358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the markdown contains something that is indented by more that the
`leadingTabs`/`leadingWs` then extra white space is incorrectly removed.
ie the following example:
```
<section data-markdown>
some text
indented text
more indented text
</section>
```
would result in the following markdown:
```
some text
indented text
more indented text
```
We can work around this problem by using a function to generate the
replace value.
|
Any news on this one? @Martinomagnifico maybe you can take a look? (Since you closed #3323, and apparently you are familiar with the code base). Thanks in advance. |
|
Yeah I closed that one because you said “Forget about it”. My knowledge about Markdown handling is limited however. |
|
Understand, thanks. It will be great if you could ping someone else who had knowledge about Markdown (or maybe I should use |
azat
added a commit
to azat/presentations
that referenced
this pull request
Feb 9, 2023
|
Friendly ping on this one, maybe this will bring someones attention... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, this is resubmit of #1831 (cc: @jerrykan)
If the markdown contains something that is indented by more that the
leadingTabs/leadingWsthen extra white space is incorrectly removed. ie the following example:would result in the following markdown:
We can work around this problem by using a function to generate the replace value.