Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Markdown plugin] add line number offset for code sections to markdown #3409

Merged
merged 2 commits into from
May 15, 2023

Conversation

flowolf
Copy link
Contributor

@flowolf flowolf commented May 12, 2023

added the option for a line number offset.

this was already possible with data-ln-number-offset now it's possible in markdown as well.
see https://revealjs.com/code/#line-number-offset-4.2.0

I've openend a PR for revealjs.com too: reveal/revealjs.com#53

What changed

the option to add line highlights is extended by an optional number offset for line numbers:

```javascript [1-5] 
or 
```javascript [256: 1-5]
or 
```javascript [256:]

are valid.

@flowolf flowolf changed the title add ln-start-from for code sections to markdown [Markdown plugin] add line number offset for code sections to markdown May 12, 2023
@hakimel hakimel merged commit 0d699ec into hakimel:master May 15, 2023
@hakimel
Copy link
Owner

hakimel commented May 15, 2023

Nice addition, thanks @flowolf!

@flowolf
Copy link
Contributor Author

flowolf commented May 15, 2023

thanks for an awesome project! happy to contribute, @hakimel!

@mattcen
Copy link
Collaborator

mattcen commented Jul 26, 2023

Closes #3386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants