fix: use setAttribute instead of innerHTML to prevent XSS
#3548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested and seems to be working well, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @hakimel
Following our previous discussion, I have made changes to use
setAttributeinstead ofinnerHTMLto prevent XSS vulnerabilities.I have created two small demos for you to try. The first demonstrates an XSS issue caused by using
innerHTML:https://jsfiddle.net/EastSun5566/9cfxeLzv/14/
The second uses
setAttributefor attribute assignment:https://jsfiddle.net/EastSun5566/rbogezv1/8/
You will notice that in the first case, an alert is triggered, while in the second, it is not. Although I believe URLs should be sanitized before setting attributes, I think this solution is good enough now.
Please let me know your thoughts. Thank you!