Fixing gulp package #3693
Closed
Fixing gulp package #3693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was erroring with ``` Error: ENOENT: no such file or directory, scandir 'reveal.js/lib' ```
Took inspiration from this issue: sindresorhus/gulp-zip#123
hakimel
added a commit
that referenced
this pull request
Oct 25, 2024
|
Thanks for letting me know about this—it's been fixed now! Your patch wasn't working for me since it tried to package another folder that didn't exist ( |
|
@hakimel thank you for the fix, perfect! 😄 |
gbastkowski
pushed a commit
to gbastkowski/reveal.js
that referenced
this pull request
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3692
gulp: fixing the
packagetaskIt was erroring with
gulp package: fixing encoding after updating to gulp 5
Took inspiration from this issue: Fonts are corrupting sindresorhus/gulp-zip#123