Feature/more languages

[haf]

Hi,

I added the latest highlight.js to the project.

[tomByrer]

That's cool you updated it!
BTW, I think it is best to keep the full list of languages supported, so the comment should read:

// Bash, C#, C++, CSS, Diff, HTML, XML, HTTP, Ini, JSON, Java, JavaScript, PHP, Perl, Python, Ruby, SQL, Clojure, GLSL, Lua, Scala, CoffeeScript, Go, Objective C, ActionScript, Markdown, F#

I used what seemed to be the most official name.

[hakimel]

Which languages were added as part of this? If the languages are uncommon I'm not sure they merit the tripled file size.

[haf]

Hi,

All languages.

If you give me a list of what languages you want added (and I want F# added - it's a common enough language) - I can regenerate the built highlight.js file.

On 5 sep 2013, at 14:33, Hakim El Hattab notifications@github.com wrote:

Which languages were added as part of this? If the languages are uncommon I'm not sure they merit the tripled file size.

—
Reply to this email directly or view it on GitHub.

[hakimel]

Sure, the current list is:

Bash, C#, C++, CSS, Diff, HTML, XML, HTTP, Ini, JSON, Java, JavaScript, PHP, Perl, Python, Ruby, SQL, Clojure, GLSL, Lua, Scala, CoffeeScript, Go, Objective C, ActionScript, Markdown

How about adding:

F#, Haml, Handlebars, Django, Erlang, Haskell, TeX

[Walther]

+1 on adding more languages.

I would personally suggest adding everything highlight.js supports as the filesize won't be incredibly big and if someone really needs this sort of micro-optimization they will probably be either inclined towards different kinds of solutions anyway or be able to easily swap the highlight.js to a smaller, more optimized version by downloading it from the website and replacing the file in plugin directory.

[haf]

I agree with Walther, it's a small size to get a lot of support. I haven't had time to redo this PR yet.

[tomByrer]

be able to easily swap the highlight.js to a smaller, more optimized version by downloading it from the website and replacing the file in plugin directory

Would be nice to add at least a link on how to do so please:

If you need to trim a few kb from the [code highlighter](http://softwaremaniacs.org/soft/highlight/en/), you can use their [custom packager](http://softwaremaniacs.org/soft/highlight/en/download/).

[haf]

That packager doesn't work because it doesn't include bugfixes nor newer languages that have been in git the last year (approx).

[Walther]

Would it be possible to have highlight.js as a git submodule? First of all that should be the "correct" way of including these kind of things, and it should make the updating process easier. It would of course require that highlight.js maintainer would have a built version of it within the repository as well, perhaps as a post-commit hook...
Edit: notified maintainer of highlight.js with this
Edit: Actually does not make much sense, as explained by author.

[isagalaev]

Hi everyone. I frankly don't see hosting pre-built modules as a "correct" way of solving this (or any) problem. This adds a whole new structural element to highlight.js that has to be maintained and also unnecessary binds it to GitHub.

To use an upstream library in a custom way it's customary to build it outside of upstream. You could build highlight.js in whatever way you need every time reveal.js is updating.

Having said that, I will probably include more languages into the hosted "common" set on the next release but I don't have a final list of those languages and unfortunately can't even roughly estimate when this might happen (which is why depending on another project's schedule is usually not a good idea anyway).

[hakimel]

Went ahead and merged this in – with all languages supported by highlight.js.