Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature prevent swipe #951

Merged
merged 2 commits into from
Sep 10, 2015
Merged

Feature prevent swipe #951

merged 2 commits into from
Sep 10, 2015

Conversation

Calyhre
Copy link

@Calyhre Calyhre commented Jun 18, 2014

Add ability to prevent swipe for child elements with the prevent-swipe attribute.

Basically, it allow users to add scroll/swipe interaction on elements, without swiping to another slide.

@hakimel hakimel merged commit ed8d90b into hakimel:dev Sep 10, 2015
hakimel added a commit that referenced this pull request Sep 10, 2015
@hakimel
Copy link
Owner

hakimel commented Sep 10, 2015

Thanks! This is really useful. Merged with two minor changes:

  • The attribute was renamed to data-prevent-swipe to match other reveal.js arguments which are prefixed with "data-".
  • The internal method was renamed from preventSwipe to isSwipePrevented. The first name sounded like the method itself was preventing swipes when it was just checking.

@Calyhre
Copy link
Author

Calyhre commented Sep 10, 2015

👍

@Calyhre Calyhre deleted the feature_prevent_swipe branch September 10, 2015 09:29
@maxmeyer
Copy link

Is there any documentation for this feature?

hakimel added a commit that referenced this pull request Sep 10, 2015
@hakimel
Copy link
Owner

hakimel commented Sep 10, 2015

@maxmeyer Good catch – it wasn't but I just added it in a151df5.

@maxmeyer
Copy link

Cool. Thanks. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants