Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Eclipse platform to 2018-12 or later #822

Closed
florianesser opened this issue Jun 4, 2020 · 4 comments
Closed

Upgrade Eclipse platform to 2018-12 or later #822

florianesser opened this issue Jun 4, 2020 · 4 comments

Comments

@florianesser
Copy link
Member

2018-12 is the first version with full Java 11 support (source).

florianesser added a commit to florianesser/hale-platform that referenced this issue Jun 22, 2020
florianesser added a commit to halestudio/hale-platform that referenced this issue Jun 22, 2020
florianesser added a commit to florianesser/hale that referenced this issue Jun 26, 2020
The implicit cast to the return type `GeometryProperty<? extends Geometry>`
now throws an error in Eclipse:

```
Incompatible generic argument types. Cannot assign eu.esdihumboldt.hale.common.schema.geometry.GeometryProperty <?> to: eu.esdihumboldt.hale.common.schema.geometry.GeometryProperty <? extends org.locationtech.jts.geom.Geometry>
```

Adds an explicit cast to mitigate.

halestudio#822
florianesser added a commit to florianesser/hale that referenced this issue Jun 26, 2020
Upgrades the Eclipse platform to 2020-03 and imports the latest hale platform
that includes the upgraded GeoTools dependencies.

halestudio#821
halestudio#822
florianesser added a commit to florianesser/hale that referenced this issue Jun 26, 2020
Adds SQLite package import to the main JDBC plugin so that `JDBCConnection`
can find the SQLite JDBC driver classes. Without the imports, the SpatiaLite
test suites fail because the JDBC driver class cannot be found by the bundle
classloader.

The SpatiaLite tests used to work before without these imports. What exactly
caused the change in behaviour remains unclear. This solution comes along as
somewhat of a hack as dependencies of plugins in the e.e.h.io.jdbc hierarchy
should not leak to here.

halestudio#822
florianesser added a commit to florianesser/hale that referenced this issue Jun 26, 2020
Adds/removes `@Override` tags to prevent compile errors.

halestudio#822
florianesser added a commit to florianesser/hale that referenced this issue Jun 26, 2020
The implicit cast to the return type `GeometryProperty<? extends Geometry>`
now throws an error in Eclipse:

```
Incompatible generic argument types. Cannot assign eu.esdihumboldt.hale.common.schema.geometry.GeometryProperty <?> to: eu.esdihumboldt.hale.common.schema.geometry.GeometryProperty <? extends org.locationtech.jts.geom.Geometry>
```

Adds an explicit cast to mitigate.

halestudio#822
florianesser added a commit to florianesser/hale that referenced this issue Jun 26, 2020
Upgrades the Eclipse platform to 2020-03 and imports the latest hale platform
that includes the upgraded GeoTools dependencies.

halestudio#821
halestudio#822
florianesser added a commit to florianesser/hale that referenced this issue Jun 26, 2020
Adds SQLite package import to the main JDBC plugin so that `JDBCConnection`
can find the SQLite JDBC driver classes. Without the imports, the SpatiaLite
test suites fail because the JDBC driver class cannot be found by the bundle
classloader.

The SpatiaLite tests used to work before without these imports. What exactly
caused the change in behaviour remains unclear. This solution comes along as
somewhat of a hack as dependencies of plugins in the e.e.h.io.jdbc hierarchy
should not leak to here.

halestudio#822
florianesser added a commit to florianesser/hale that referenced this issue Jun 26, 2020
Adds/removes `@Override` tags to prevent compile errors.

halestudio#822
florianesser added a commit to florianesser/hale that referenced this issue Jun 26, 2020
The implicit cast to the return type `GeometryProperty<? extends Geometry>`
now throws an error in Eclipse:

```
Incompatible generic argument types. Cannot assign eu.esdihumboldt.hale.common.schema.geometry.GeometryProperty <?> to: eu.esdihumboldt.hale.common.schema.geometry.GeometryProperty <? extends org.locationtech.jts.geom.Geometry>
```

Adds an explicit cast to mitigate.

halestudio#822
florianesser added a commit to florianesser/hale that referenced this issue Jun 26, 2020
Upgrades the Eclipse platform to 2020-03 and imports the latest hale platform
that includes the upgraded GeoTools dependencies.

halestudio#821
halestudio#822
florianesser added a commit to florianesser/hale that referenced this issue Jun 26, 2020
Adds SQLite package import to the main JDBC plugin so that `JDBCConnection`
can find the SQLite JDBC driver classes. Without the imports, the SpatiaLite
test suites fail because the JDBC driver class cannot be found by the bundle
classloader.

The SpatiaLite tests used to work before without these imports. What exactly
caused the change in behaviour remains unclear. This solution comes along as
somewhat of a hack as dependencies of plugins in the e.e.h.io.jdbc hierarchy
should not leak to here.

halestudio#822
florianesser added a commit to florianesser/hale that referenced this issue Jun 26, 2020
Adds/removes `@Override` tags to prevent compile errors.

halestudio#822
florianesser added a commit to florianesser/hale that referenced this issue Jun 26, 2020
The implicit cast to the return type `GeometryProperty<? extends Geometry>`
now throws an error in Eclipse:

```
Incompatible generic argument types. Cannot assign eu.esdihumboldt.hale.common.schema.geometry.GeometryProperty <?> to: eu.esdihumboldt.hale.common.schema.geometry.GeometryProperty <? extends org.locationtech.jts.geom.Geometry>
```

Adds an explicit cast to mitigate.

halestudio#822
florianesser added a commit to florianesser/hale that referenced this issue Jun 26, 2020
Upgrades the Eclipse platform to 2020-03 and imports the latest hale platform
that includes the upgraded GeoTools dependencies.

halestudio#821
halestudio#822
florianesser added a commit to florianesser/hale that referenced this issue Jun 26, 2020
Adds SQLite package import to the main JDBC plugin so that `JDBCConnection`
can find the SQLite JDBC driver classes. Without the imports, the SpatiaLite
test suites fail because the JDBC driver class cannot be found by the bundle
classloader.

The SpatiaLite tests used to work before without these imports. What exactly
caused the change in behaviour remains unclear. This solution comes along as
somewhat of a hack as dependencies of plugins in the e.e.h.io.jdbc hierarchy
should not leak to here.

halestudio#822
florianesser added a commit to florianesser/hale that referenced this issue Jun 26, 2020
Adds/removes `@Override` tags to prevent compile errors.

halestudio#822
florianesser added a commit that referenced this issue Jun 26, 2020
The implicit cast to the return type `GeometryProperty<? extends Geometry>`
now throws an error in Eclipse:

```
Incompatible generic argument types. Cannot assign eu.esdihumboldt.hale.common.schema.geometry.GeometryProperty <?> to: eu.esdihumboldt.hale.common.schema.geometry.GeometryProperty <? extends org.locationtech.jts.geom.Geometry>
```

Adds an explicit cast to mitigate.

#822
florianesser added a commit that referenced this issue Jun 26, 2020
Upgrades the Eclipse platform to 2020-03 and imports the latest hale platform
that includes the upgraded GeoTools dependencies.

#821
#822
florianesser added a commit that referenced this issue Jun 26, 2020
Adds SQLite package import to the main JDBC plugin so that `JDBCConnection`
can find the SQLite JDBC driver classes. Without the imports, the SpatiaLite
test suites fail because the JDBC driver class cannot be found by the bundle
classloader.

The SpatiaLite tests used to work before without these imports. What exactly
caused the change in behaviour remains unclear. This solution comes along as
somewhat of a hack as dependencies of plugins in the e.e.h.io.jdbc hierarchy
should not leak to here.

#822
florianesser added a commit that referenced this issue Jun 26, 2020
Adds/removes `@Override` tags to prevent compile errors.

#822
florianesser added a commit to florianesser/hale that referenced this issue Jun 26, 2020
32-bit support was dropped in Eclipse 2018-12, so remove the repsective
Travis CI builds. Also, upgrade the build platform to Ubuntu 18.04.

halestudio#822
florianesser added a commit to florianesser/hale that referenced this issue Jun 26, 2020
32-bit support was dropped in Eclipse 2018-12, so remove the repspective
Travis CI builds. Also, upgrade the build platform to Ubuntu 18.04.

halestudio#822
florianesser added a commit to florianesser/hale that referenced this issue Jun 26, 2020
32-bit support was dropped in Eclipse 2018-12, so remove the respective
Travis CI builds. Also, upgrade the build platform to Ubuntu 18.04.

halestudio#822
florianesser added a commit to florianesser/hale that referenced this issue Jun 26, 2020
32-bit support was dropped in Eclipse 2018-12, so remove the respective
Travis CI builds.

halestudio#822
florianesser added a commit to florianesser/hale that referenced this issue Jun 26, 2020
32-bit support was dropped in Eclipse 2018-12, so remove the respective
Travis CI builds.

halestudio#822
thorsten-reitz pushed a commit that referenced this issue Jun 26, 2020
32-bit support was dropped in Eclipse 2018-12, so remove the respective
Travis CI builds.

#822
@thorsten-reitz
Copy link
Member

thorsten-reitz commented Jun 29, 2020

There are some extra arrows and an extra compass on the welcome page - maybe an artifact of this upgrade?
grafik

@thorsten-reitz thorsten-reitz added this to the 4.0.0 milestone Jun 30, 2020
@thorsten-reitz
Copy link
Member

Startup time seems to have improved with the latest builds, maybe a result of removing the server parts?

@stempler
Copy link
Member

maybe a result of removing the server parts?

No server bundles were part of the desktop application. That was just about removing stuff that is not used anymore (the server product).

@thorsten-reitz
Copy link
Member

Hm, OK. Just timed the difference, it isn't massive - the build from 20200619 is starting about 2s slower (15s) than the latest build (13s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants