Revising template structure #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halfzebra
force-pushed
the
revising-template-structure
branch
from
2bf268e to
cae17c9
Compare
fobos
reviewed
Jun 13, 2017
scripts/build.js
Outdated
| // publicPath, | ||
| // buildFolder, | ||
| // useYarn | ||
| // ) |
There was a problem hiding this comment.
Can we remove commented code?
There was a problem hiding this comment.
I'll replace that with CEA-specific logic. This PR is still WIP.
|
halfzebra
force-pushed
the
revising-template-structure
branch
2 times, most recently
from
8df883e to
53491d5
Compare
This was referenced Jun 14, 2017
Closed
halfzebra
force-pushed
the
revising-template-structure
branch
2 times, most recently
from
cf9997f to
8dea778
Compare
BREAKING CHANGE: added `public/` folder and changed the config to serve static assets from it.
halfzebra
force-pushed
the
revising-template-structure
branch
from
e99bc05 to
db88cbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the functionality of
/publicfolder from Create React App.What?
Potentially fixes the stuff from #100, #106, #118 and partially #123
Why?
We were having trouble figuring out the future structure in #138, I spoke to @eeue56, @fobos and @gyzerok and have concluded, that we should reduce the scope of the task.
This one adds an option for serving assets outside the webpack module system and adds a new fancy build script.