Add helper for cross-compiling Halide generators. #6366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexreinking
added
buildbot_test_nothing
alexreinking
force-pushed
the
alex/add_halide_generator
branch
from
c4fa50c to
58af0ac
Compare
alexreinking
force-pushed
the
alex/add_halide_generator
branch
from
58af0ac to
d4a875d
Compare
This was referenced Oct 29, 2021
Created a new function, `add_halide_generator`, that helps users write correct
cross-compiling builds by establishing the following convention for them:
1. Define Halide generators and libraries in the same project
2. Assume two builds: a host build and a cross build.
3. When creating a generator, check to see if we can load a pre-built version of
the target.
4. If so, just use it, and add aliases to make sure all the names line up.
5. If not, make sure the full Halide package is loaded and create a target for
the generator.
a. If `CMAKE_CROSSCOMPILING` is set, then _warn_ the user (the variable is
unreliable on macOS) that something seems fishy.
b. Create export rules for the generator. It creates a package
`PACKAGE_NAME` and appends to its `EXPORT_FILE`.
c. Create a custom target also named `PACKAGE_NAME` for building the
generators.
d. Create an alias `${PACKAGE_NAMESPACE}${TARGET}`.
6. Users are expected to use the alias in conjunction `add_halide_library`.
Users can test the existence of `TARGET` to determine whether a pre-built one
was loaded (and set additional properties if not).
7. Setting `${PACKAGE_NAME}_ROOT` is enough to load pre-built generators.
`PACKAGE_NAME` is `${PROJECT_NAME}-generators` by default.
`PACKAGE_NAMESPACE` is `${PROJECT_NAME}::generators::` by default.
`EXPORT_FILE` is `${PROJECT_BINARY_DIR}/cmake/${PACKAGE_NAME}-config.cmake` by
default.
Users are free to avoid the helper if it would not fit their workflow.
alexreinking
force-pushed
the
alex/add_halide_generator
branch
from
fff7422 to
e0ddb92
Compare
|
What needs to happen for this to land -- do we have enough test coverage? Do we need to update apps/hannk to use this rule? |
I have already updated HANNK to use this in a separate branch... would you like me to group these changes together, then? |
Not necessary as long as it all lands close enough together, do as you see fit for reviewability |
alexreinking
removed
skip_buildbots
|
Here, I'm adding the HANNK change so that we can look at how the helper will be used in a real world scenario. |
steven-johnson
approved these changes
Nov 1, 2021
|
basically all good |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new function,
add_halide_generator, that helps users write correct cross-compiling builds by establishing the following convention for creating a generator namedTARGET:a. If
CMAKE_CROSSCOMPILINGis set, then warn the user (the variable is unreliable on macOS) that something seems fishy.b. Create export rules for the generator. It creates a package
PACKAGE_NAMEand appends to itsEXPORT_FILE.c. Create a custom target also named
PACKAGE_NAMEfor building the generators.d. Create an alias
${PACKAGE_NAMESPACE}${TARGET}.add_halide_library. Users can test the existence ofTARGETto determine whether a pre-built one was loaded (and set additional properties if not).${PACKAGE_NAME}_ROOTis enough to load pre-built generators.PACKAGE_NAMEis${PROJECT_NAME}-halide_generatorsby default.PACKAGE_NAMESPACEis${PROJECT_NAME}::halide_generators::by default.EXPORT_FILEis${PROJECT_BINARY_DIR}/cmake/${PACKAGE_NAME}-config.cmakeby default.Users are free to avoid the helper if it would not fit their workflow.
This will be useful to integrate into HANNK. It abstracts the approach in #6365 and will hopefully enable cross-compilation for the other apps, too.
Skipping buildbots because only the
test/integrationcode uses it for now (and only the GHA tests use this)