Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

fix(menu): 对菜单做了一些调整和优化。 #267

Merged
merged 2 commits into from
Nov 24, 2020
Merged

fix(menu): 对菜单做了一些调整和优化。 #267

merged 2 commits into from
Nov 24, 2020

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Nov 21, 2020

  1. 删除了菜单的动画效果
  2. 当拖拽到菜单底部时，会触发滚动效果
  3. 现在拖为子节点会方便那么一点（也不是很完美）
  4. 当菜单头不在可视区域时，会触发跟随，不需要拖拽完菜单还需要返回顶部再保存了。

@LIlGG
fix(menu): 对菜单做了一些调整和优化。
a5e0dda 
1. 删除了菜单的动画效果
2. 当拖拽到菜单底部时，会触发滚动效果
3. 现在拖为子节点会方便那么一点（也不是很完美）
4. 当菜单头不在可视区域时，会触发跟随，不需要拖拽完菜单还需要返回顶部再保存了。
@LIlGG LIlGG requested a review from ruibaby November 21, 2020 12:04
@LIlGG
Copy link
Member Author

LIlGG commented Nov 21, 2020

本来打算再加上子菜单折叠什么的 不过该恰饭了

@ruibaby
Copy link
Member

ruibaby commented Nov 24, 2020

其他问题不大，我把 animation 设置为了 100，不然在拖动的时候显得特别鬼畜。

@ruibaby ruibaby added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 24, 2020
@ruibaby ruibaby merged commit ae5887a into halo-dev:master Nov 24, 2020
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
@LIlGG @ruibaby
fix(menu): 对菜单做了一些调整和优化。 (halo-dev/console#267)
558c1e0 
* fix(menu): 对菜单做了一些调整和优化。

1. 删除了菜单的动画效果
2. 当拖拽到菜单底部时，会触发滚动效果
3. 现在拖为子节点会方便那么一点（也不是很完美）
4. 当菜单头不在可视区域时，会触发跟随，不需要拖拽完菜单还需要返回顶部再保存了。

* pref: add animation for menu drag.

Co-authored-by: Ryan Wang <i@ryanc.cc>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ruibaby ruibaby ruibaby approved these changes

Assignees

@LIlGG LIlGG

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LIlGG @ruibaby