Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

feat: add actuator view page #832

Merged
merged 6 commits into from
Jan 31, 2023
Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jan 30, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

添加 Actuator 信息查看页面。适配 halo-dev/halo#3182

todo:

  • 页面入口

Which issue(s) this PR fixes:

Fixes halo-dev/halo#3055

Screenshots:

image

Special notes for your reviewer:

测试方式:

  1. Halo 需要切换到 Provide system config endpoint halo#3182 分支。
  2. Console 需要 pnpm build:packages
  3. 访问 http://localhost:8090/console#/actuator

Does this PR introduce a user-facing change?

Console 端添加系统信息查看页面

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 30, 2023
@vercel
Copy link

vercel bot commented Jan 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 30, 2023 at 8:22AM (UTC)

@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and lan-yonghui January 30, 2023 04:20
@ruibaby ruibaby changed the title feat: add actuator view page WIP: feat: add actuator view page Jan 30, 2023
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2023
@JohnNiang
Copy link
Member

IMO,这类配置不用在这里展示。毕竟在系统设置页面已经有所体现了。

image

@ruibaby ruibaby changed the title WIP: feat: add actuator view page feat: add actuator view page Jan 30, 2023
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2023
@ruibaby
Copy link
Member Author

ruibaby commented Jan 30, 2023

image

暂时将入口放在了这个位置,名称也改为了系统概览。有其他建议可以提出。

@ruibaby
Copy link
Member Author

ruibaby commented Jan 30, 2023

IMO,这类配置不用在这里展示。毕竟在系统设置页面已经有所体现了。

image

已修改。

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

image

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jan 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 21530d3 into halo-dev:main Jan 31, 2023
@ruibaby ruibaby modified the milestones: 2.0.x, 2.2.0 Jan 31, 2023
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
#### What type of PR is this?

/kind feature

#### What this PR does / why we need it:

添加 Actuator 信息查看页面。适配 halo-dev#3182

todo:

- [x] 页面入口

#### Which issue(s) this PR fixes:

Fixes halo-dev#3055

#### Screenshots:

![image](https://user-images.githubusercontent.com/21301288/215386617-e3aafc6d-777d-49e8-93c9-b9432623e98e.png)


#### Special notes for your reviewer:

测试方式:

1. Halo 需要切换到 halo-dev#3182 分支。
2. Console 需要 `pnpm build:packages`
3. 访问 http://localhost:8090/console#/actuator

#### Does this PR introduce a user-facing change?

```release-note
Console 端添加系统信息查看页面
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

支持在控制台查看版本等信息
3 participants