Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

perf: fix CLS issue of actuator page #840

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 7, 2023

What type of PR is this?

/kind improvement

What this PR does / why we need it:

修复 Actuator 页面抖动的问题。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#3225

Special notes for your reviewer:

测试方式:

  1. 测试进入系统概览页面是否会出现 Console 端系统概览页面因为外部访问链接提示会出现抖动 halo#3225 中提到的页面抖动问题。

Does this PR introduce a user-facing change?

修复 Console 端进入系统概览页面会抖动的问题。

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 7, 2023
@vercel
Copy link

vercel bot commented Feb 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 7, 2023 at 8:04AM (UTC)

@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Feb 7, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit db2fe14 into halo-dev:main Feb 7, 2023
@ruibaby ruibaby deleted the perf/actuator-flash branch February 10, 2023 03:44
@ruibaby
Copy link
Member Author

ruibaby commented Feb 10, 2023

/cherry-pick release-2.2

@halo-dev-bot
Copy link

@ruibaby: new pull request created: #842

In response to this:

/cherry-pick release-2.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Feb 10, 2023
This is an automated cherry-pick of #840

/assign ruibaby

```release-note
修复 Console 端进入系统概览页面会抖动的问题。
```
@ruibaby ruibaby modified the milestones: 2.3.x, 2.3.0 Feb 10, 2023
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

修复 Actuator 页面抖动的问题。

#### Which issue(s) this PR fixes:

Fixes halo-dev#3225

#### Special notes for your reviewer:

测试方式:

1. 测试进入系统概览页面是否会出现 halo-dev#3225 中提到的页面抖动问题。

#### Does this PR introduce a user-facing change?

```release-note
修复 Console 端进入系统概览页面会抖动的问题。
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console 端系统概览页面因为外部访问链接提示会出现抖动
4 participants