This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
perf: improve the validation rules for username #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
f2c-ci-robot
bot
added
release-note
guqing
reviewed
Feb 21, 2023
guqing
reviewed
Feb 21, 2023
JohnNiang
reviewed
Feb 21, 2023
Co-authored-by: guqing <38999863+guqing@users.noreply.github.com>
…erf/username-validation
|
特殊字符目前只支持连字符（-）和点（.）？是否考虑增加适配邮箱的特殊字符？或者考虑登录时可以使用邮箱进行登陆？ |
|
|
/lgtm |
|
ping @halo-dev/sig-halo-console |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
JohnNiang
pushed a commit
to JohnNiang/halo
that referenced
this pull request
Mar 2, 2023
#### What type of PR is this? /kind improvement #### What this PR does / why we need it: 优化用户名的校验规则，目前采用 DNS 名称的规则，即：必须以字母（a-z或A-Z）开头，并包含字母数字字符（a-z，A-Z，0-9）和连字符（-）。每一段名称以字母结尾（a-z或A-Z）。名称以点（.）分隔 #### Which issue(s) this PR fixes: Fixes halo-dev#3239 #### Screenshots: #### Special notes for your reviewer: 测试方式： 1. 新建用户，检查用户名输入规则是否符合预期。 #### Does this PR introduce a user-facing change? ```release-note 优化 Console 端新建用户时，用户名的校验规则。 ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
What this PR does / why we need it:
优化用户名的校验规则，目前采用 DNS 名称的规则，即：必须以字母（a-z或A-Z）开头，并包含字母数字字符（a-z，A-Z，0-9）和连字符（-）。每一段名称以字母结尾（a-z或A-Z）。名称以点（.）分隔
Which issue(s) this PR fixes:
Fixes halo-dev/halo#3239
Screenshots:
Special notes for your reviewer:
测试方式：
Does this PR introduce a user-facing change?