Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to refactor deletion of extension data #4519

Closed
JohnNiang opened this issue Aug 30, 2023 · 0 comments · Fixed by #4526
Closed

Request to refactor deletion of extension data #4519

JohnNiang opened this issue Aug 30, 2023 · 0 comments · Fixed by #4526
Assignees
Labels
area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement.
Milestone

Comments

@JohnNiang
Copy link
Member

JohnNiang commented Aug 30, 2023

What is version of Halo has the issue?

2.9.0-SNAPSHOT

What database are you using?

H2

What is your deployment method?

Docker

Your site address.

localhost

What happened?

Currently, we use GcReconciler to detect whether extension will be recycled or not. It might not work for extensions created by plugins or after a system restart. So that we have to delete extensions manually.

As a result, we request to refactor GcReconciler to watch extension updates as well to ensure all deletable extensions will be recycled normally.

/kind improvement
/area core
/assign

Relevant log output

{
  "spec": {
    "cronBackupName": "cron-backup-default",
    "backupName": "cron-backup-AUGGW",
    "storagePolicyName": "attachment-policy-HuPYt",
    "storageGroupName": ""
  },
  "status": {
    "startTimestamp": "2023-08-22T08:25:05.103351Z",
    "completionTimestamp": "2023-08-22T08:25:14.823289Z",
    "lastProbeBackupPhase": "SUCCEEDED",
    "phase": "SUCCEEDED",
    "attachmentName": "3aee897f-5828-480f-96bd-0db8f480c6fd"
  },
  "apiVersion": "migration.halo.run/v1alpha1",
  "kind": "Synchronization",
  "metadata": {
    "generateName": "backup-sync-",
    "finalizers": [],
    "name": "backup-sync-NeknA",
    "labels": {
      "migration.halo.run/cron-backup-name": "cron-backup-default"
    },
    "version": 0,
    "creationTimestamp": "2023-08-22T08:25:00.046725Z",
    "deletionTimestamp": "2023-08-22T08:35:00.036002Z"
  }
}

Additional information

image
@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. area/core Issues or PRs related to the Halo Core labels Aug 30, 2023
@JohnNiang JohnNiang added this to the 2.9.0 milestone Aug 30, 2023
f2c-ci-robot bot pushed a commit that referenced this issue Aug 31, 2023
…e recycled (#4526)

#### What type of PR is this?

/kind bug
/area core
/milestone 2.9.x

#### What this PR does / why we need it:

As I mentioned in <#4519>, some extensions which are deletable cannot be recycled by GC. This PR provides an ability to watch scheme changes and recycles deletable extensions.

#### Which issue(s) this PR fixes:

Fixes #4519

#### Does this PR introduce a user-facing change?

```release-note
修复因重启后部分可被回收的资源一直处于删除中的状态
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant