-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add role information for user-related custom endpoint #3372
Conversation
@guqing: GitHub didn't allow me to request PR reviews from the following users: halo-dev/sig-halo. Note that only halo-dev members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
可以配合 halo-dev/console#882 测试。
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#### What type of PR is this? /kind improvement #### What this PR does / why we need it: 重构获取用户信息的请求方式,无需再请求所有角色即可获取当前用户的角色信息,适配:halo-dev/halo#3372 相关 PR:#847 #### Which issue(s) this PR fixes: Fixes halo-dev/halo#3342 #### Special notes for your reviewer: 测试方式: 1. Halo 需要切换到 halo-dev/halo#3372 分支。 2. Console 需要 `pnpm install && pnpm build:packages` 3. 测试用户列表、登录、检查角色信息是否显示正确。 #### Does this PR introduce a user-facing change? ```release-note 优化 Console 端用户角色标识的显示名称。 ```
Codecov Report
@@ Coverage Diff @@
## main #3372 +/- ##
============================================
- Coverage 60.99% 60.79% -0.21%
- Complexity 2490 2491 +1
============================================
Files 399 399
Lines 12664 12709 +45
Branches 1043 1044 +1
============================================
+ Hits 7725 7727 +2
- Misses 4431 4474 +43
Partials 508 508
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
/lgtm |
修复由 halo-dev/halo#3372 导致获取用户错误的问题。 /kind bug ```release-note None ```
#### What type of PR is this? /kind improvement #### What this PR does / why we need it: 重构获取用户信息的请求方式,无需再请求所有角色即可获取当前用户的角色信息,适配:halo-dev#3372 相关 PR:halo-dev/console#847 #### Which issue(s) this PR fixes: Fixes halo-dev#3342 #### Special notes for your reviewer: 测试方式: 1. Halo 需要切换到 halo-dev#3372 分支。 2. Console 需要 `pnpm install && pnpm build:packages` 3. 测试用户列表、登录、检查角色信息是否显示正确。 #### Does this PR introduce a user-facing change? ```release-note 优化 Console 端用户角色标识的显示名称。 ```
What type of PR is this?
/kind feature
/kind api-change
/area core
/milestone 2.3.x
What this PR does / why we need it:
获取用户信息的 API 响应体包含关联角色信息
/apis/api.console.halo.run/v1alpha1/users/{name}
/apis/api.console.halo.run/v1alpha1/users/-
由于 API 响应体结构的改变,需要 Console 适配
Which issue(s) this PR fixes:
Fixes #3342
Special notes for your reviewer:
/cc @halo-dev/sig-halo
Does this PR introduce a user-facing change?