-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor project structure for a better development #3552
Refactor project structure for a better development #3552
Conversation
Signed-off-by: John Niang <johnniang@fastmail.com>
Signed-off-by: John Niang <johnniang@fastmail.com>
Codecov Report
@@ Coverage Diff @@
## main #3552 +/- ##
============================================
- Coverage 61.72% 59.75% -1.98%
+ Complexity 2572 2188 -384
============================================
Files 408 337 -71
Lines 12921 11273 -1648
Branches 1026 837 -189
============================================
- Hits 7976 6736 -1240
+ Misses 4458 4132 -326
+ Partials 487 405 -82
... and 379 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
需要将下列 utils 放入 api 模块:
还需要将 core/extension 下的那些 extension 放进来比如 Post、SinglePage、Comment 等,以及依赖到 infra 下的 ConditionList、ConditionStatus 等 还需要将下列类放进去
|
|
期望插件中可以引入一个依赖然后自动包含所有 halo 引入过的依赖 并且 scope 为 provide/compileOnly 这样插件可以直接使用且不会打包到插件中 |
According to https://docs.spring.io/spring-boot/docs/current/reference/html/using.html\#using.devtools.restart.customizing-the-classload Signed-off-by: John Niang <johnniang@fastmail.com>
Signed-off-by: John Niang <johnniang@fastmail.com>
Signed-off-by: John Niang <johnniang@fastmail.com>
Signed-off-by: John Niang <johnniang@fastmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#### What type of PR is this? /kind bug /area console #### What this PR does / why we need it: 修正 Console 构建的输出目录,此问题由 #3552 导致。 #### Does this PR introduce a user-facing change? ```release-note None ```
What type of PR is this?
/kind cleanup
/area core
What this PR does / why we need it:
This PR totally refactor project structure for a better plugin development. Now we can maintain and publish api and platform modules at Halo application side, which will be references by plugins.
Currently, we can execute command
./gradlew clean publish
to publish api and platform modules into local Maven repository, so that we can refer these dependencies (run.halo.tools.platform:plugin:2.4.0-SNAPSHOT
andrun.halo.app:api:2.4.0-SNAPSHOT
) in plugin projects.I will make another pull request to publish api library and platforms into Maven central repository.
Modules explanation:
If we want to build application only(exclude check and jar), we have to execute the command below:
The executable Jar will be generated at folder
application/build/libs/
.If we want to build a Docker image, we could execute the command below:
Which issue(s) this PR fixes:
Fixes #2730
Special notes for your reviewer:
Does this PR introduce a user-facing change?