-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add the notification mechanism implementation #4527
Conversation
@guqing: The provided milestone is not valid for this repository. Milestones in this repository: [ Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## main #4527 +/- ##
============================================
+ Coverage 61.05% 61.79% +0.73%
- Complexity 2610 2780 +170
============================================
Files 379 402 +23
Lines 13606 14568 +962
Branches 960 1009 +49
============================================
+ Hits 8307 9002 +695
- Misses 4832 5077 +245
- Partials 467 489 +22
|
0c58b31
to
d904c68
Compare
fe1eb75
to
a572c51
Compare
287257a
to
0661fe3
Compare
Signed-off-by: guqing <1484563614@qq.com>
bddbb51
to
a3561ad
Compare
/ping @halo-dev/sig-halo |
Signed-off-by: Ryan Wang <i@ryanc.cc>
application/src/main/resources/extensions/notification-templates.yaml
Outdated
Show resolved
Hide resolved
application/src/main/resources/extensions/notification-templates.yaml
Outdated
Show resolved
Hide resolved
application/src/main/resources/extensions/notification-templates.yaml
Outdated
Show resolved
Hide resolved
application/src/main/resources/extensions/notification-templates.yaml
Outdated
Show resolved
Hide resolved
# Conflicts: # application/src/main/resources/extensions/role-template-authenticated.yaml
# Conflicts: # application/src/main/resources/extensions/role-template-authenticated.yaml
f58e8f6
to
8418b42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/milestone 2.10.x
/area core
What this PR does / why we need it:
新增消息和通知机制的实现
how to test it?
Which issue(s) this PR fixes:
Fixes #4045
Does this PR introduce a user-facing change?