Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add supports for check started status after start plugin operation #4558

Merged
merged 2 commits into from
Sep 7, 2023
Merged

feat: add supports for check started status after start plugin operation #4558

merged 2 commits into from
Sep 7, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 6, 2023

What type of PR is this?

/area console
/kind improvement
/milestone 2.10.x

What this PR does / why we need it:

支持在启动插件之后检测插件的启动状态，防止直接刷新之后 bundle.js 的内容没有及时更新。

Does this PR introduce a user-facing change?

优化 Console 端启动插件的逻辑

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 6, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.10.x milestone Sep 6, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/console Issues or PRs related to the Halo Console label Sep 6, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and LIlGG September 6, 2023 09:07
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Sep 6, 2023
@ruibaby ruibaby force-pushed the feat/check-started-status branch from efbac81 to 7a8255f Compare September 6, 2023 10:04
@ruibaby
Copy link
Member Author

ruibaby commented Sep 6, 2023

/cherrypick release-2.9

@halo-dev-bot
Copy link
Collaborator

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.9 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ruibaby
Refine checkStatus function
532646b 
Signed-off-by: Ryan Wang <i@ryanc.cc>
guqing
guqing reviewed Sep 7, 2023
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #4558 (532646b) into main (2baf6ae) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4558   +/-   ##
=========================================
  Coverage     61.02%   61.02%           
  Complexity     2560     2560           
=========================================
  Files           373      373           
  Lines         13149    13149           
  Branches        937      937           
=========================================
  Hits           8024     8024           
  Misses         4670     4670           
  Partials        455      455

JohnNiang
JohnNiang approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit a1ea355 into halo-dev:main Sep 7, 2023
2 checks passed
@halo-dev-bot halo-dev-bot mentioned this pull request Sep 7, 2023
Merged
@halo-dev-bot
Copy link
Collaborator

@ruibaby: new pull request created: #4568

In response to this:

/cherrypick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JohnNiang JohnNiang added kind/bug Categorizes issue or PR as related to a bug. and removed kind/improvement Categorizes issue or PR as related to a improvement. labels Sep 7, 2023
f2c-ci-robot bot pushed a commit that referenced this pull request Sep 7, 2023
@halo-dev-bot
[release-2.9] feat: add supports for check started status after start…
b3f9416 
… plugin operation (#4568)

This is an automated cherry-pick of #4558

/assign ruibaby

```release-note
优化 Console 端启动插件的逻辑
```
@ruibaby ruibaby modified the milestones: 2.10.x, 2.10.0 Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing guqing left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

@Aanko Aanko Awaiting requested review from Aanko

@LIlGG LIlGG Awaiting requested review from LIlGG

Assignees

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ruibaby @halo-dev-bot @JohnNiang @guqing